Skip to content

Adding dotenv to cli #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
assaftibm wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Adding dotenv to cli #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dependencies = [
"pyyaml>=6.0",
"tqdm>=4.64.0",
"numpy>=1.22.0",
"python-dotenv>=1.2.1",
]

[project.optional-dependencies]
Expand Down Expand Up @@ -60,7 +61,6 @@ frontier-cs = [
"google-genai>=1.55.0",
"google-generativeai>=0.8.5",
"numpy>=2.0.0", # Frontier-CS requires numpy 2.x
"python-dotenv>=1.2.1",
"skypilot>=0.10.5",
]
prompt-optimization = [
Expand Down
4 changes: 4 additions & 0 deletions skydiscover/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
import traceback
from typing import Optional

from dotenv import load_dotenv

from skydiscover import Runner
from skydiscover.config import (
_parse_model_spec,
Expand All @@ -23,6 +25,8 @@

logger = logging.getLogger(__name__)

load_dotenv()

@gemini-code-assist gemini-code-assist Bot Mar 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Calling load_dotenv() at the module level can cause unintended side effects, especially during testing. For example, tests/test_cli_checkpoint_discovery.py imports a function from this module, which would trigger load_dotenv() and could make tests dependent on a .env file or modify the environment unexpectedly.

It's better to move this call inside the main() function to ensure it only runs when the CLI is executed as a script. This will isolate the side effect of loading environment variables to the application's entry point. You should remove this line and add load_dotenv() to your main function, like so:

def main() -> int:
    """Synchronous entry point for the skydiscover console script."""
    load_dotenv()
    return asyncio.run(main_async())

@assaftibm assaftibm Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make this change if requested. Note that there are main() and main_async(). I'm not sure which of them to update (or maybe both).


_SEARCH_CHOICES = [
"evox",
"adaevolve",
Expand Down
3 changes: 2 additions & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading