Skip to content

workflow: add traceroute workflow#1661

Open
dvandra wants to merge 1 commit into
skydive-project:masterfrom
dvandra:workflows_traceroute
Open

workflow: add traceroute workflow#1661
dvandra wants to merge 1 commit into
skydive-project:masterfrom
dvandra:workflows_traceroute

Conversation

@dvandra

@dvandra dvandra commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@dvandra

dvandra commented Feb 15, 2019

Copy link
Copy Markdown
Contributor Author

run skydive-cdd-overview-tests

@masco

masco commented Feb 20, 2019

Copy link
Copy Markdown
Member

You need to rebase and change the parameter names according to the new yaml tags

Comment thread statics/workflows/traceroute.yaml Outdated
@dvandra dvandra force-pushed the workflows_traceroute branch from 2162ab2 to 8112cbe Compare February 20, 2019 11:07
Comment thread statics/workflows/traceroute.yaml Outdated
Comment thread statics/workflows/traceroute.yaml Outdated
Comment thread statics/workflows/traceroute.yaml
@dvandra dvandra force-pushed the workflows_traceroute branch from 8112cbe to fec0202 Compare February 21, 2019 08:27
@masco

masco commented Feb 26, 2019

Copy link
Copy Markdown
Member

I propose to have two inner functions called getIP and getMAC . it will make the code more readable and simple.

@dvandra dvandra force-pushed the workflows_traceroute branch from fec0202 to 0e3448b Compare February 27, 2019 19:13
@lebauce

lebauce commented Mar 22, 2019

Copy link
Copy Markdown
Member

@dvandra It would be super nice to add a test for it as the ones in tests/workflow_test.go as our workflow mechanism is still pretty new, changes to it may break your workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants