Conversation
|
Looks like we have |
package.json
Outdated
| "main": "index.js", | ||
| "repository": "github:slackapi/reacjilator", | ||
| "scripts": { | ||
| "lint": "", |
There was a problem hiding this comment.
note: I tried to run biomjs but it required significant changes for the linter to pass. I figured it's better to keep the linter workflow and have a noop npm run lint than remove the workflow.
There was a problem hiding this comment.
🌲 question: Do we have a lint workflow from before? I agree that it'd be nice to add but we might save that for a follow up issue if not here.
🗣️ ramble: Editing to add that I do find this above and am less certain on keeping or removing this. Please feel free to ignore this comment as wanted!
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@mwbrooks Wowie - big respect for bringing this sample up to standards all around!
I left a few comments of some polish that we might want to have before merging this, but this is meaningful maintenance and improvement for future change 🙏
package.json
Outdated
| "main": "index.js", | ||
| "repository": "github:slackapi/reacjilator", | ||
| "scripts": { | ||
| "lint": "", |
There was a problem hiding this comment.
🌲 question: Do we have a lint workflow from before? I agree that it'd be nice to add but we might save that for a follow up issue if not here.
🗣️ ramble: Editing to add that I do find this above and am less certain on keeping or removing this. Please feel free to ignore this comment as wanted!
Co-authored-by: Eden Zimbelman <zim@o526.net>
Co-authored-by: Eden Zimbelman <zim@o526.net>
Co-authored-by: Eden Zimbelman <zim@o526.net>
|
@zimeg Great suggestions all around! I've resolved each of your suggestions. If you throw an approval on this, feel free to smash the merge button afterwards! 🎸 |
2 participants
Type of change
Summary
This pull request removes an invalid
CODEOWNERSfile and adds the standard.github/directory, which includes:.github/CODEOWNERS.github/CODE_OF_CONDUCT.md.github/CONTRIBUTING.md.github/SECURITY.mdRequirements