Quietly log error on UDP_NETRESET ioctl on Windows. - #1453
Merged
Conversation
nbrownus
reviewed
Aug 19, 2025
| return | ||
| } | ||
| u.l.WithError(err).Error("unexpected udp socket receive error") | ||
| u.l.WithError(err).Warn("unexpected udp socket receive error") |
Collaborator
There was a problem hiding this comment.
I suspect this can get really noisy if we failed to disable the icmp error reporting on a busy host.
Are we able to do any error equality checking and suppress logging when we encounter those icmp errors?
Collaborator
Author
There was a problem hiding this comment.
oh sorry, I got deep into trying to repro scenarios and forgot I promised to dampen this. Let me see what I can do here.
Collaborator
Author
|
@nbrownus I failed to generate ICMP TTL errors and get them to actually be received by the host. In lieu of that, I hacked up some dampening code so that the unexpected warnings will not be output any more often than once per minute. |
nbrownus
approved these changes
Aug 19, 2025
alexm-occ
pushed a commit
to oneclick-ag/nebula
that referenced
this pull request
Nov 13, 2025
* Quietly log error on UDP_NETRESET ioctl on Windows. * dampen unexpected error warnings
63 tasks
nbrownus
pushed a commit
that referenced
this pull request
Jan 9, 2026
* Quietly log error on UDP_NETRESET ioctl on Windows. * dampen unexpected error warnings
nbrownus
added a commit
that referenced
this pull request
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows is returning errors on UDP_NETRESET ioctls now. This code was inspired by golang stdlib code, and included as a best effort to minimize the number of errors returned by Windows udp receive operations.
When this fails, Nebula falls back to the generic UDP code.
This PR updates the ioctls to quietly log failures and continue processing.
I manually tested this and I do not see errors being returned by the udp receive operation when the Windows host receives icmp unreachable messages.