cert-v2 chores - #1466
Conversation
| return ok | ||
| } | ||
|
|
||
| // TODO: CERT-V2 IsLighthouseAddr should be sufficient, we just need to update the vpnAddrs for lighthouses after a handshake |
There was a problem hiding this comment.
I think it is more burdensome to do that? This feels fine to me, but I'm open to making the change if you feel differently
There was a problem hiding this comment.
The goal of this TODO was to remove the loop and made a stab at how we might do it.
#1464 gave us a more reliable lh.addrMap for non primary vpn addrs in the static host map and a TODO in that PR was to update the RemoteList.vpnAddrs once we received and authenticated the certificate from the remote (to fix the remote_allow_ranges). With that, we would have a way to kill this loop.
There was a problem hiding this comment.
Ahhh I like that.
Do you feel this is a 1.10 blocker?
There was a problem hiding this comment.
Not specifically, it is a performance regression in some ways but I think it has low impact.
There was a problem hiding this comment.
oh actually this is easier than I thought, I think. Pushed something that I think takes care of it
There was a problem hiding this comment.
scooting this to new MR so we can merge everything else
18064eb to
6672324
Compare
3 participants
No description provided.