update RemoteList.vpnAddrs when we complete a handshake - #1467
Merged
Conversation
nbrownus
requested changes
Sep 5, 2025
JackDoan
force-pushed
the
cert-v2-cleanup-more
branch
from
September 5, 2025 22:04
20f1a0a to
d737ef2
Compare
nbrownus
reviewed
Sep 6, 2025
nbrownus
reviewed
Sep 9, 2025
nbrownus
approved these changes
Sep 10, 2025
Collaborator
|
I think there is a follow up item here which is to update the documentation to cover both ipv4 and ipv6 overlay addresses with the allow lists. You can get in a situation where you think you've only allowed a certain ipv4 range but if you don't disallow the ipv6 range on the underlay then you might be in for a surprise. |
63 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.