add locks around replay window updates - #1802
Merged
Merged
Conversation
JackDoan
force-pushed
the
locking-decrypt-2
branch
from
July 15, 2026 14:18
89a9051 to
63224eb
Compare
JackDoan
marked this pull request as ready for review
July 15, 2026 17:00
JackDoan
force-pushed
the
locking-decrypt-2
branch
from
July 17, 2026 20:22
02a6c0c to
19431ab
Compare
wadey
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the right approach to keep
multiportas performant as possible, while avoiding races.