Open
Conversation
Added to fast reader: - parse TES bias - format headers - read selection of channels - handle IQ_mode
Collaborator
Author
|
adding @BrianJKoopman to ask if I did anything really bad to the packaging. I've checked that |
Use memory views for speed and less memory use. Also get dimensions from file to pre-allocate read arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far I've tested this on a small
.datfile and confirmed that the result is identical to the current implementation with different values for theIQ_modeandchannelarguments.I'll do some more testing, but we should consider if we want to support the python-only reader or just remove it and clean up the code.
It would also be useful to double check the build steps now to make sure the cython compilation doesn't cause any issues.