Skip to content

Fix: Make university names case-insensitive in dashboard registration graph - #24

Closed
icy-r with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-bfe9ed53-29b4-4299-b773-94bc138231a8
Closed

Fix: Make university names case-insensitive in dashboard registration graph#24
icy-r with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-bfe9ed53-29b4-4299-b773-94bc138231a8

Conversation

Copilot AI commented Oct 5, 2025

Copy link
Copy Markdown
Contributor
  • Analyze the current implementation in registrations.jsx
  • Update the data aggregation logic to normalize university names (case-insensitive)
  • Aggregate counts for universities with same name (different cases)
  • Test the changes with linter and build
  • Verify the implementation
  • Revert pnpm-lock.yaml to original state

Changes Made:

  • Modified src/components/dashboard/registrations.jsx to group universities by normalized (lowercase) name
  • Universities with the same name but different cases (e.g., "SLIIT" and "sliit") are now aggregated together
  • The first occurrence's casing is preserved for display purposes
  • Counts are summed up for all case variations of the same university name
  • Reverted pnpm-lock.yaml to its original state (unintended changes removed)
Original prompt

This section details on the original issue you should resolve

<issue_title>update dashboard team graph to consider university names as non case sensitive values</issue_title>
<issue_description></issue_description>

<agent_instructions>create new branch and follow branching and commit rules</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #23

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@vercel

vercel Bot commented Oct 5, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
bashaway-admin-portal Ready Ready Preview Comment Oct 5, 2025 0:28am

Co-authored-by: icy-r <87885588+icy-r@users.noreply.github.com>
Copilot AI changed the title [WIP] update dashboard team graph to consider university names as non case sensitive values Fix: Make university names case-insensitive in dashboard registration graph Oct 5, 2025
Copilot AI requested a review from icy-r October 5, 2025 12:18
@icy-r
icy-r requested a review from Copilot October 5, 2025 12:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the dashboard registration graph to handle university names case-insensitively, preventing duplicate entries for the same university with different casing.

  • Implements case-insensitive aggregation of university registration counts
  • Uses a Map-based approach to group universities by normalized (lowercase) names
  • Preserves original casing for display while combining counts for case variations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@icy-r

icy-r commented Oct 5, 2025

Copy link
Copy Markdown
Member

@copilot Error: You have commit messages with errors
and do not commit pnpm-lock.yaml

Co-authored-by: icy-r <87885588+icy-r@users.noreply.github.com>

Copilot AI commented Oct 5, 2025

Copy link
Copy Markdown
Contributor Author

@copilot Error: You have commit messages with errors
and do not commit pnpm-lock.yaml

I've reverted the pnpm-lock.yaml changes in commit 7fd45f8. The lock file is now back to its original state.

Regarding the "Initial plan" commit message: This commit was created as an empty progress report and doesn't follow the conventional commit format. Since force push is not available, I cannot amend or rebase to fix this historical commit. However, all subsequent commits now follow the correct format:

  • "Fix: make university names case-insensitive in dashboard graph"
  • "Revert: remove unintended pnpm-lock.yaml changes"

The PR now only contains changes to src/components/dashboard/registrations.jsx as intended.

@icy-r

icy-r commented Oct 5, 2025

Copy link
Copy Markdown
Member

Copilot AI commented Oct 5, 2025

Copy link
Copy Markdown
Contributor Author

@copilot https://github.com/sliit-foss/bashaway-admin-portal/actions/runs/18258710341/job/51983704497?pr=24

The CI is failing due to the "Initial plan" commit (59c4f8c) which doesn't follow conventional commit format. This was an empty progress report commit.

Since force push is not available, I cannot rewrite git history to fix this commit message. The commit needs a type prefix like "Chore: Initial plan" or "Docs: Initial plan".

Options:

  1. You can manually amend/rebase this commit and force push
  2. I can continue with additional commits, but this one will remain in the history and continue to fail CI
  3. The PR can be closed and a new one opened with proper commit messages from the start

The actual code changes in commits a9b35ba and 7fd45f8 are correct and follow the conventional commit format.

icy-r commented Oct 5, 2025

Copy link
Copy Markdown
Member

The 'Initial plan' commit (59c4f8c) in this PR doesn't follow conventional commit format and was causing CI failures. Since force push is not available to rewrite the git history, I've created a new PR #25 with only the valid commits that follow the proper commit message convention.

The code changes are identical - this is purely to fix the commit history issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update dashboard team graph to consider university names as non case sensitive values

3 participants