Skip to content

Feature/refactor with sorting fix - #46

Merged
Akalanka47000 merged 2 commits into
developmentfrom
feature/refactor-with-sorting-fix
Nov 29, 2025
Merged

Feature/refactor with sorting fix#46
Akalanka47000 merged 2 commits into
developmentfrom
feature/refactor-with-sorting-fix

Conversation

@icy-r

@icy-r icy-r commented Nov 29, 2025

Copy link
Copy Markdown
Member

This pull request introduces new filtering and sorting options for questions and submissions, updates default sort directions to descending, and makes a minor fix to a React hook dependency. Additionally, it enables manual triggering of the staging deployment workflow via GitHub Actions.

Filtering and sorting improvements:

  • Added a "Max Score" filter to the questionFilters array in src/filters/question.js, allowing users to filter questions by their maximum score.
  • Added a "Grading Type" filter to the submissionFilters array in src/filters/submission.js, enabling users to filter submissions by whether they are automatically or manually graded.
  • Set the default sort direction for "Sort by points" in questionSorts and "Sort by score" in submissionSorts to descending (from 0 to -1) for improved usability. [1] [2]

Workflow and code quality enhancements:

  • Enabled the workflow_dispatch trigger in .github/workflows/staging-deploy.yml, allowing manual deployments to staging from the GitHub UI.
  • Fixed the dependency array in the useAuth hook in src/hooks/auth.jsx by including navigate, addressing a potential React warning.

@vercel

vercel Bot commented Nov 29, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
bashaway-portal Ready Ready Preview Comment Nov 29, 2025 2:48pm

@icy-r
icy-r requested a review from Akalanka47000 November 29, 2025 08:34
@icy-r icy-r self-assigned this Nov 29, 2025
@icy-r
icy-r changed the base branch from main to development November 29, 2025 14:11
Comment thread src/filters/submission.js Outdated
Comment on lines +17 to +28
key: "automatically_graded",
label: "Grading Type",
options: [
{
key: "true",
label: "Auto Graded"
},
{
key: "false",
label: "Manually Graded"
}
]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event portal does not need this filter @icy-r

@Akalanka47000
Akalanka47000 merged commit 5a79d47 into development Nov 29, 2025
5 of 6 checks passed
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.1.2
🛫 Deployed preview to https://portal.staging.bashaway.sliitfoss.org/preview/pr-46/
on branch gh-pages at 2025-11-29 14:49 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants