BackendBuilder: move creating renderer into own function#11203
Open
Murmele wants to merge 9 commits intoslint-ui:masterfrom
Open
BackendBuilder: move creating renderer into own function#11203Murmele wants to merge 9 commits intoslint-ui:masterfrom
Murmele wants to merge 9 commits intoslint-ui:masterfrom
Conversation
Reason: So it can be reused by the popup
Murmele
commented
Mar 31, 2026
tronical
approved these changes
Mar 31, 2026
Member
tronical
left a comment
tronical
left a comment
There was a problem hiding this comment.
This looks like a reasonable simplification, the indirection via a function pointer may not be worth it :)
Contributor
Author
|
I will wait until 1.16 is out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it can be reused in future code like the popup