fix renamed enum and struct re-exports in rust codegen#11228
fix renamed enum and struct re-exports in rust codegen#11228amirHdev wants to merge 2 commits intoslint-ui:masterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5b320d65d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5f18a0d to
06684d7
Compare
|
Thanks for tackling this issue. The other problem is that this is a breaking change and i don't know if this is acceptable. |
To make that design correct we’d need to decide whether the old name should stop being a normal public export in those cases which is a larger API shape. |
- preserve renamed public identities for re-exports and direct imports without local aliases - keep alias imports semantically tied to the original type - allow same-origin renamed enums in strict two-way binding checks - cover the Rust codegen regression from issue 9094 Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
8bc1bb8 to
10ba915
Compare
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
10ba915 to
8947276
Compare
Summary
Fix a compiler issue where renamed exported enums and structs could lose their public identity during
import or re-export resolution.
Fixes #9094
Update
The major problem was that renamed public identities are needed for Rust codegen but plain alias imports must still remain semantically.