Conversation
LeonMatthes
left a comment
LeonMatthes
left a comment
There was a problem hiding this comment.
No objection to making the preview protocol a separate crate but I don't think we should remove lsp-types from the main LSP.
anlumo
force-pushed
the
anlumo/lsp-refactor
branch
from
6974a69 to
c12c880
Compare
ogoffart
left a comment
ogoffart
left a comment
There was a problem hiding this comment.
Please make sure the docs is correct.
Also let's wait until 1.16 is branched to merge this.
Regarding the purpose of the crate, i'm thinking there might be some need to also have more than the preview protocol, but also some feature that are needed for the preview, such as highlighting of items and maybe the selection mode or other stuff, that should be common between different crate that offer live preview (LSP's live preview, live-preview for C++/Rust, viewer) and maybe it would bellng in that one crate. Therefore i'm thinking that a neame like "i-slint-live-preview" would probably be better than just having a crate for the protocol. But we can discuss the purpose later and right now just go with the protocol, but let's wait until we have the actual viewer before that. That's why i'd like to wait and not have to release this with 1.16.
We can discuss this further.
| @@ -0,0 +1,14 @@ | |||
| // Copyright © SixtyFPS GmbH <info@slint.dev> | |||
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0 | |||
|
|
|||
There was a problem hiding this comment.
Please add #![doc = include_str!("README.md")]
3 participants
The remote viewer needs access to the preview protocol, so it needs to be extracted to its own crate.