llr: Fix panic when two-way binding ListView viewport to a global#11281
Merged
llr: Fix panic when two-way binding ListView viewport to a global#11281
Conversation
Allow LLR ListViewInfo to hold global references, not just local ones. The remove_aliases pass can rewrite viewport properties to point to globals when using `<=>`, which caused a panic in lower_to_item_tree. Fixes: #11095
tronical
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow LLR ListViewInfo to hold global references, not just local ones. The remove_aliases pass can rewrite viewport properties to point to globals when using
<=>, which caused a panic in lower_to_item_tree.Fixes: #11095