Quant Project (WIP)#1000
Open
Alexander-Sol wants to merge 58 commits into
Open
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…roup and BioPolymerGroup accordingly
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nbollis
reviewed
Dec 18, 2025
Member
There was a problem hiding this comment.
It may be worth moving some of the static Experimental Design methods out of metamorpheus and into mzlib as either static funcctions or interface members.
| /// <summary> | ||
| /// This will need to be implemented or changed or relocated later. Right now it's just a placeholder. | ||
| /// </summary> | ||
| public static class QuantificationWriter |
Member
There was a problem hiding this comment.
If writing require unique functions, you could possibly do this as an interface and an abstract factory. That way the engine constructor calls a writer factor, passes in quant parameters, and receives either the TMT writer or the LFQ writer.
|
|
||
| // 3) Normalize peptide matrix | ||
| var peptideMatrixNorm = NormalizationStrategy.NormalizePeptideIntensities(peptideMatrixRaw, ModifiedBioPolymers); | ||
|
|
Member
There was a problem hiding this comment.
Will you need to switch between quant types here at all? Or is everything the same and handled by the strategies?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds off of Shortreeds PR #993 . First step in addressing Issue #996