Update Handling of Sequence Variants (Part 6): SequenceVariant AreValid#969
Open
trishorts wants to merge 40 commits into
Open
Update Handling of Sequence Variants (Part 6): SequenceVariant AreValid#969trishorts wants to merge 40 commits into
trishorts wants to merge 40 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #969 +/- ##
==========================================
- Coverage 81.00% 80.87% -0.13%
==========================================
Files 269 269
Lines 38826 38957 +131
Branches 4241 4272 +31
==========================================
+ Hits 31450 31508 +58
- Misses 6640 6692 +52
- Partials 736 757 +21
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the existing method for evaluating if a sequence variant is valid just isn't up to snuf. This PR adds improved bool for AreValid that considers all changes at the sequence and modification level of a variant