Update logging messages to use consistent casing for placeholders

snow-jallen · snow-jallen · commit f5b6005e8d0d · 2025-09-04T22:30:29.000-06:00
diff --git a/HomeSpeaker.WebAssembly/Services/AnchorSyncService.cs b/HomeSpeaker.WebAssembly/Services/AnchorSyncService.cs
@@ -37,37 +37,37 @@ public async Task StartAsync()
             // Subscribe to hub events
             _hubConnection.On<AnchorDefinition>("AnchorDefinitionCreated", (anchorDefinition) =>
             {
-                _logger.LogInformation("Received anchor definition created: {name}", anchorDefinition.Name);
+                _logger.LogInformation("Received anchor definition created: {Name}", anchorDefinition.Name);
                 OnAnchorDefinitionCreated?.Invoke(anchorDefinition);
             });
 
             _hubConnection.On<AnchorDefinition>("AnchorDefinitionUpdated", (anchorDefinition) =>
             {
-                _logger.LogInformation("Received anchor definition updated: {name}", anchorDefinition.Name);
+                _logger.LogInformation("Received anchor definition updated: {Name}", anchorDefinition.Name);
                 OnAnchorDefinitionUpdated?.Invoke(anchorDefinition);
             });
 
             _hubConnection.On<int>("AnchorDefinitionDeactivated", (anchorDefinitionId) =>
             {
-                _logger.LogInformation("Received anchor definition deactivated: {id}", anchorDefinitionId);
+                _logger.LogInformation("Received anchor definition deactivated: {Id}", anchorDefinitionId);
                 OnAnchorDefinitionDeactivated?.Invoke(anchorDefinitionId);
             });
 
             _hubConnection.On<UserAnchor>("UserAnchorAssigned", (userAnchor) =>
             {
-                _logger.LogInformation("Received user anchor assigned: user {userId}, anchor {anchorId}", userAnchor.UserId, userAnchor.AnchorDefinitionId);
+                _logger.LogInformation("Received user anchor assigned: user {UserId}, anchor {AnchorId}", userAnchor.UserId, userAnchor.AnchorDefinitionId);
                 OnUserAnchorAssigned?.Invoke(userAnchor);
             });
 
             _hubConnection.On<string, int>("UserAnchorRemoved", (userId, anchorDefinitionId) =>
             {
-                _logger.LogInformation("Received user anchor removed: user {userId}, anchor {anchorId}", userId, anchorDefinitionId);
+                _logger.LogInformation("Received user anchor removed: user {UserId}, anchor {AnchorId}", userId, anchorDefinitionId);
                 OnUserAnchorRemoved?.Invoke(userId, anchorDefinitionId);
             });
 
             _hubConnection.On<int, bool, DateTime?>("DailyAnchorCompletionUpdated", (dailyAnchorId, isCompleted, completedAt) =>
             {
-                _logger.LogInformation("Received daily anchor completion updated: {dailyAnchorId}, completed: {isCompleted}", dailyAnchorId, isCompleted);
+                _logger.LogInformation("Received daily anchor completion updated: {DailyAnchorId}, completed: {IsCompleted}", dailyAnchorId, isCompleted);
                 OnDailyAnchorCompletionUpdated?.Invoke(dailyAnchorId, isCompleted, completedAt);
             });
 
@@ -76,7 +76,7 @@ public async Task StartAsync()
             {
                 if (error != null)
                 {
-                    _logger.LogWarning("SignalR connection closed with error: {error}", error.Message);
+                    _logger.LogWarning("SignalR connection closed with error: {Error}", error.Message);
                 }
                 else
                 {
@@ -90,7 +90,7 @@ public async Task StartAsync()
 
             // Start connection
             await _hubConnection.StartAsync();
-            _logger.LogInformation("SignalR connection started successfully to {url}", $"{anchorsApiAddress}/anchorHub");
+            _logger.LogInformation("SignalR connection started successfully to {Url}", $"{anchorsApiAddress}/anchorHub");
 
             // Join the anchor updates group
             await _hubConnection.SendAsync("JoinAnchorGroup");
diff --git a/HomeSpeaker.WebAssembly/Services/HomeSpeakerService.cs b/HomeSpeaker.WebAssembly/Services/HomeSpeakerService.cs
@@ -15,7 +15,7 @@ public class HomeSpeakerService
         string address = config["ServerAddress"] ?? throw new MissingConfigException("ServerAddress");
         logger.LogInformation($"I was about to use {address}");
         address = hostEnvironment.BaseAddress;
-        logger.LogInformation("But instead I'll use {address}", address);
+    logger.LogInformation("But instead I'll use {Address}", address);
         var channel = GrpcChannel.ForAddress(address, new GrpcChannelOptions
         {
             HttpHandler = new GrpcWebHandler(new HttpClientHandler())
@@ -116,13 +116,13 @@ public async Task RenamePlaylistAsync(string oldName, string newName)
     {
         try
         {
-            logger.LogInformation("Calling RenamePlaylist gRPC method: {oldName} -> {newName}", oldName, newName);
+            logger.LogInformation("Calling RenamePlaylist gRPC method: {OldName} -> {NewName}", oldName, newName);
             await client.RenamePlaylistAsync(new RenamePlaylistRequest { OldName = oldName, NewName = newName });
-            logger.LogInformation("Successfully called RenamePlaylist gRPC method: {oldName} -> {newName}", oldName, newName);
+            logger.LogInformation("Successfully called RenamePlaylist gRPC method: {OldName} -> {NewName}", oldName, newName);
         }
         catch (Exception ex)
         {
-            logger.LogError(ex, "Error calling RenamePlaylist gRPC method: {oldName} -> {newName}", oldName, newName);
+            logger.LogError(ex, "Error calling RenamePlaylist gRPC method: {OldName} -> {NewName}", oldName, newName);
             throw;
         }
     }
@@ -134,26 +134,26 @@ public async Task DeletePlaylistAsync(string playlistName)
 
     public async Task ReorderPlaylistSongsAsync(string playlistName, List<string> songPaths)
     {
-        logger.LogInformation("Calling ReorderPlaylistSongs gRPC method for playlist: {playlistName}", playlistName);
+    logger.LogInformation("Calling ReorderPlaylistSongs gRPC method for playlist: {PlaylistName}", playlistName);
         await client.ReorderPlaylistSongsAsync(new ReorderPlaylistSongsRequest
         {
             PlaylistName = playlistName,
             SongPaths = { songPaths }
         });
-        logger.LogInformation("Successfully called ReorderPlaylistSongs gRPC method for playlist: {playlistName}", playlistName);
+    logger.LogInformation("Successfully called ReorderPlaylistSongs gRPC method for playlist: {PlaylistName}", playlistName);
     }
 
     public async Task UpdateSongAsync(int songId, string name, string artist, string album)
     {
-        logger.LogInformation("Calling UpdateSong gRPC method for song: {songId}", songId);
+    logger.LogInformation("Calling UpdateSong gRPC method for song: {SongId}", songId);
         await client.UpdateSongAsync(new UpdateSongRequest
         {
             SongId = songId,
             Name = name,
             Artist = artist,
             Album = album
         });
-        logger.LogInformation("Successfully called UpdateSong gRPC method for song: {songId}", songId);
+    logger.LogInformation("Successfully called UpdateSong gRPC method for song: {SongId}", songId);
     }
 
     readonly char[] separators = new[] { '/', '\\' };
@@ -175,12 +175,12 @@ public async Task<IEnumerable<string>> GetFolders()
 
                 if (directory == "c:")
                 {
-                    logger.LogInformation("Directory: '{directory}' ({path})", directory, s.Path);
+                    logger.LogInformation("Directory: '{Directory}' ({Path})", directory, s.Path);
                 }
 
                 if (!folders.Contains(directory))
                 {
-                    logger.LogInformation("Directory: '{directory}' ({path})", directory, s.Path);
+                    logger.LogInformation("Directory: '{Directory}' ({Path})", directory, s.Path);
                     folders.Add(directory);
                 }
             }
diff --git a/HomeSpeaker.WebAssembly/Services/IAnchorService.cs b/HomeSpeaker.WebAssembly/Services/IAnchorService.cs
@@ -96,7 +96,7 @@ public async Task<AnchorDefinition> CreateAnchorDefinitionAsync(CreateAnchorDefi
         }
         catch (Exception ex)
         {
-            logger.LogError(ex, "Failed to update anchor definition {id}", id);
+            logger.LogError(ex, "Failed to update anchor definition {Id}", id);
             throw;
         }
     }
@@ -110,7 +110,7 @@ public async Task<bool> DeactivateAnchorDefinitionAsync(int id)
         }
         catch (Exception ex)
         {
-            logger.LogError(ex, "Failed to deactivate anchor definition {id}", id);
+            logger.LogError(ex, "Failed to deactivate anchor definition {Id}", id);
             return false;
         }
     }
@@ -127,7 +127,7 @@ public async Task<IEnumerable<UserAnchor>> GetUserAnchorsAsync(string userId)
         }
         catch (Exception ex)
         {
-            logger.LogError(ex, "Failed to get user anchors for {userId}", userId);
+            logger.LogError(ex, "Failed to get user anchors for {UserId}", userId);
             return [];
         }
     }
@@ -159,7 +159,7 @@ public async Task<bool> RemoveAnchorFromUserAsync(string userId, int anchorDefin
         }
         catch (Exception ex)
         {
-            logger.LogError(ex, "Failed to remove anchor from user {userId}", userId);
+            logger.LogError(ex, "Failed to remove anchor from user {UserId}", userId);
             return false;
         }
     }
@@ -176,7 +176,7 @@ public async Task<IEnumerable<DailyAnchor>> GetDailyAnchorsAsync(string userId,
         }
         catch (Exception ex)
         {
-            logger.LogError(ex, "Failed to get daily anchors for {userId} on {date}", userId, date);
+            logger.LogError(ex, "Failed to get daily anchors for {UserId} on {Date}", userId, date);
             return [];
         }
     }
@@ -203,7 +203,7 @@ public async Task<IEnumerable<DailyAnchor>> GetDailyAnchorsRangeAsync(string use
         }
         catch (Exception ex)
         {
-            logger.LogError(ex, "Failed to get daily anchors range for {userId}", userId);
+            logger.LogError(ex, "Failed to get daily anchors range for {UserId}", userId);
             return [];
         }
     }
@@ -217,7 +217,7 @@ public async Task CreateDailyAnchorsAsync(string userId, DateOnly date)
         }
         catch (Exception ex)
         {
-            logger.LogError(ex, "Failed to create daily anchors for {userId} on {date}", userId, date);
+            logger.LogError(ex, "Failed to create daily anchors for {UserId} on {Date}", userId, date);
             throw;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -37,37 +37,37 @@ public async Task StartAsync()`
`37`	`37`	`// Subscribe to hub events`
`38`	`38`	`_hubConnection.On<AnchorDefinition>("AnchorDefinitionCreated", (anchorDefinition) =>`
`39`	`39`	`{`
`40`		`- _logger.LogInformation("Received anchor definition created: {name}", anchorDefinition.Name);`
	`40`	`+ _logger.LogInformation("Received anchor definition created: {Name}", anchorDefinition.Name);`
`41`	`41`	`OnAnchorDefinitionCreated?.Invoke(anchorDefinition);`
`42`	`42`	`});`
`43`	`43`
`44`	`44`	`_hubConnection.On<AnchorDefinition>("AnchorDefinitionUpdated", (anchorDefinition) =>`
`45`	`45`	`{`
`46`		`- _logger.LogInformation("Received anchor definition updated: {name}", anchorDefinition.Name);`
	`46`	`+ _logger.LogInformation("Received anchor definition updated: {Name}", anchorDefinition.Name);`
`47`	`47`	`OnAnchorDefinitionUpdated?.Invoke(anchorDefinition);`
`48`	`48`	`});`
`49`	`49`
`50`	`50`	`_hubConnection.On<int>("AnchorDefinitionDeactivated", (anchorDefinitionId) =>`
`51`	`51`	`{`
`52`		`- _logger.LogInformation("Received anchor definition deactivated: {id}", anchorDefinitionId);`
	`52`	`+ _logger.LogInformation("Received anchor definition deactivated: {Id}", anchorDefinitionId);`
`53`	`53`	`OnAnchorDefinitionDeactivated?.Invoke(anchorDefinitionId);`
`54`	`54`	`});`
`55`	`55`
`56`	`56`	`_hubConnection.On<UserAnchor>("UserAnchorAssigned", (userAnchor) =>`
`57`	`57`	`{`
`58`		`- _logger.LogInformation("Received user anchor assigned: user {userId}, anchor {anchorId}", userAnchor.UserId, userAnchor.AnchorDefinitionId);`
	`58`	`+ _logger.LogInformation("Received user anchor assigned: user {UserId}, anchor {AnchorId}", userAnchor.UserId, userAnchor.AnchorDefinitionId);`
`59`	`59`	`OnUserAnchorAssigned?.Invoke(userAnchor);`
`60`	`60`	`});`
`61`	`61`
`62`	`62`	`_hubConnection.On<string, int>("UserAnchorRemoved", (userId, anchorDefinitionId) =>`
`63`	`63`	`{`
`64`		`- _logger.LogInformation("Received user anchor removed: user {userId}, anchor {anchorId}", userId, anchorDefinitionId);`
	`64`	`+ _logger.LogInformation("Received user anchor removed: user {UserId}, anchor {AnchorId}", userId, anchorDefinitionId);`
`65`	`65`	`OnUserAnchorRemoved?.Invoke(userId, anchorDefinitionId);`
`66`	`66`	`});`
`67`	`67`
`68`	`68`	`_hubConnection.On<int, bool, DateTime?>("DailyAnchorCompletionUpdated", (dailyAnchorId, isCompleted, completedAt) =>`
`69`	`69`	`{`
`70`		`- _logger.LogInformation("Received daily anchor completion updated: {dailyAnchorId}, completed: {isCompleted}", dailyAnchorId, isCompleted);`
	`70`	`+ _logger.LogInformation("Received daily anchor completion updated: {DailyAnchorId}, completed: {IsCompleted}", dailyAnchorId, isCompleted);`
`71`	`71`	`OnDailyAnchorCompletionUpdated?.Invoke(dailyAnchorId, isCompleted, completedAt);`
`72`	`72`	`});`
`73`	`73`
`@@ -76,7 +76,7 @@ public async Task StartAsync()`
`76`	`76`	`{`
`77`	`77`	`if (error != null)`
`78`	`78`	`{`
`79`		`- _logger.LogWarning("SignalR connection closed with error: {error}", error.Message);`
	`79`	`+ _logger.LogWarning("SignalR connection closed with error: {Error}", error.Message);`
`80`	`80`	`}`
`81`	`81`	`else`
`82`	`82`	`{`
`@@ -90,7 +90,7 @@ public async Task StartAsync()`
`90`	`90`
`91`	`91`	`// Start connection`
`92`	`92`	`await _hubConnection.StartAsync();`
`93`		`- _logger.LogInformation("SignalR connection started successfully to {url}", $"{anchorsApiAddress}/anchorHub");`
	`93`	`+ _logger.LogInformation("SignalR connection started successfully to {Url}", $"{anchorsApiAddress}/anchorHub");`
`94`	`94`
`95`	`95`	`// Join the anchor updates group`
`96`	`96`	`await _hubConnection.SendAsync("JoinAnchorGroup");`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public class HomeSpeakerService`
`15`	`15`	`string address = config["ServerAddress"] ?? throw new MissingConfigException("ServerAddress");`
`16`	`16`	`logger.LogInformation($"I was about to use {address}");`
`17`	`17`	`address = hostEnvironment.BaseAddress;`
`18`		`- logger.LogInformation("But instead I'll use {address}", address);`
	`18`	`+ logger.LogInformation("But instead I'll use {Address}", address);`
`19`	`19`	`var channel = GrpcChannel.ForAddress(address, new GrpcChannelOptions`
`20`	`20`	`{`
`21`	`21`	`HttpHandler = new GrpcWebHandler(new HttpClientHandler())`
`@@ -116,13 +116,13 @@ public async Task RenamePlaylistAsync(string oldName, string newName)`
`116`	`116`	`{`
`117`	`117`	`try`
`118`	`118`	`{`
`119`		`- logger.LogInformation("Calling RenamePlaylist gRPC method: {oldName} -> {newName}", oldName, newName);`
	`119`	`+ logger.LogInformation("Calling RenamePlaylist gRPC method: {OldName} -> {NewName}", oldName, newName);`
`120`	`120`	`await client.RenamePlaylistAsync(new RenamePlaylistRequest { OldName = oldName, NewName = newName });`
`121`		`- logger.LogInformation("Successfully called RenamePlaylist gRPC method: {oldName} -> {newName}", oldName, newName);`
	`121`	`+ logger.LogInformation("Successfully called RenamePlaylist gRPC method: {OldName} -> {NewName}", oldName, newName);`
`122`	`122`	`}`
`123`	`123`	`catch (Exception ex)`
`124`	`124`	`{`
`125`		`- logger.LogError(ex, "Error calling RenamePlaylist gRPC method: {oldName} -> {newName}", oldName, newName);`
	`125`	`+ logger.LogError(ex, "Error calling RenamePlaylist gRPC method: {OldName} -> {NewName}", oldName, newName);`
`126`	`126`	`throw;`
`127`	`127`	`}`
`128`	`128`	`}`
`@@ -134,26 +134,26 @@ public async Task DeletePlaylistAsync(string playlistName)`
`134`	`134`
`135`	`135`	`public async Task ReorderPlaylistSongsAsync(string playlistName, List<string> songPaths)`
`136`	`136`	`{`
`137`		`- logger.LogInformation("Calling ReorderPlaylistSongs gRPC method for playlist: {playlistName}", playlistName);`
	`137`	`+ logger.LogInformation("Calling ReorderPlaylistSongs gRPC method for playlist: {PlaylistName}", playlistName);`
`138`	`138`	`await client.ReorderPlaylistSongsAsync(new ReorderPlaylistSongsRequest`
`139`	`139`	`{`
`140`	`140`	`PlaylistName = playlistName,`
`141`	`141`	`SongPaths = { songPaths }`
`142`	`142`	`});`
`143`		`- logger.LogInformation("Successfully called ReorderPlaylistSongs gRPC method for playlist: {playlistName}", playlistName);`
	`143`	`+ logger.LogInformation("Successfully called ReorderPlaylistSongs gRPC method for playlist: {PlaylistName}", playlistName);`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`public async Task UpdateSongAsync(int songId, string name, string artist, string album)`
`147`	`147`	`{`
`148`		`- logger.LogInformation("Calling UpdateSong gRPC method for song: {songId}", songId);`
	`148`	`+ logger.LogInformation("Calling UpdateSong gRPC method for song: {SongId}", songId);`
`149`	`149`	`await client.UpdateSongAsync(new UpdateSongRequest`
`150`	`150`	`{`
`151`	`151`	`SongId = songId,`
`152`	`152`	`Name = name,`
`153`	`153`	`Artist = artist,`
`154`	`154`	`Album = album`
`155`	`155`	`});`
`156`		`- logger.LogInformation("Successfully called UpdateSong gRPC method for song: {songId}", songId);`
	`156`	`+ logger.LogInformation("Successfully called UpdateSong gRPC method for song: {SongId}", songId);`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`readonly char[] separators = new[] { '/', '\\' };`
`@@ -175,12 +175,12 @@ public async Task<IEnumerable<string>> GetFolders()`
`175`	`175`
`176`	`176`	`if (directory == "c:")`
`177`	`177`	`{`
`178`		`- logger.LogInformation("Directory: '{directory}' ({path})", directory, s.Path);`
	`178`	`+ logger.LogInformation("Directory: '{Directory}' ({Path})", directory, s.Path);`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`if (!folders.Contains(directory))`
`182`	`182`	`{`
`183`		`- logger.LogInformation("Directory: '{directory}' ({path})", directory, s.Path);`
	`183`	`+ logger.LogInformation("Directory: '{Directory}' ({Path})", directory, s.Path);`
`184`	`184`	`folders.Add(directory);`
`185`	`185`	`}`
`186`	`186`	`}`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public async Task<AnchorDefinition> CreateAnchorDefinitionAsync(CreateAnchorDefi`
`96`	`96`	`}`
`97`	`97`	`catch (Exception ex)`
`98`	`98`	`{`
`99`		`- logger.LogError(ex, "Failed to update anchor definition {id}", id);`
	`99`	`+ logger.LogError(ex, "Failed to update anchor definition {Id}", id);`
`100`	`100`	`throw;`
`101`	`101`	`}`
`102`	`102`	`}`
`@@ -110,7 +110,7 @@ public async Task<bool> DeactivateAnchorDefinitionAsync(int id)`
`110`	`110`	`}`
`111`	`111`	`catch (Exception ex)`
`112`	`112`	`{`
`113`		`- logger.LogError(ex, "Failed to deactivate anchor definition {id}", id);`
	`113`	`+ logger.LogError(ex, "Failed to deactivate anchor definition {Id}", id);`
`114`	`114`	`return false;`
`115`	`115`	`}`
`116`	`116`	`}`
`@@ -127,7 +127,7 @@ public async Task<IEnumerable<UserAnchor>> GetUserAnchorsAsync(string userId)`
`127`	`127`	`}`
`128`	`128`	`catch (Exception ex)`
`129`	`129`	`{`
`130`		`- logger.LogError(ex, "Failed to get user anchors for {userId}", userId);`
	`130`	`+ logger.LogError(ex, "Failed to get user anchors for {UserId}", userId);`
`131`	`131`	`return [];`
`132`	`132`	`}`
`133`	`133`	`}`
`@@ -159,7 +159,7 @@ public async Task<bool> RemoveAnchorFromUserAsync(string userId, int anchorDefin`
`159`	`159`	`}`
`160`	`160`	`catch (Exception ex)`
`161`	`161`	`{`
`162`		`- logger.LogError(ex, "Failed to remove anchor from user {userId}", userId);`
	`162`	`+ logger.LogError(ex, "Failed to remove anchor from user {UserId}", userId);`
`163`	`163`	`return false;`
`164`	`164`	`}`
`165`	`165`	`}`
`@@ -176,7 +176,7 @@ public async Task<IEnumerable<DailyAnchor>> GetDailyAnchorsAsync(string userId,`
`176`	`176`	`}`
`177`	`177`	`catch (Exception ex)`
`178`	`178`	`{`
`179`		`- logger.LogError(ex, "Failed to get daily anchors for {userId} on {date}", userId, date);`
	`179`	`+ logger.LogError(ex, "Failed to get daily anchors for {UserId} on {Date}", userId, date);`
`180`	`180`	`return [];`
`181`	`181`	`}`
`182`	`182`	`}`
`@@ -203,7 +203,7 @@ public async Task<IEnumerable<DailyAnchor>> GetDailyAnchorsRangeAsync(string use`
`203`	`203`	`}`
`204`	`204`	`catch (Exception ex)`
`205`	`205`	`{`
`206`		`- logger.LogError(ex, "Failed to get daily anchors range for {userId}", userId);`
	`206`	`+ logger.LogError(ex, "Failed to get daily anchors range for {UserId}", userId);`
`207`	`207`	`return [];`
`208`	`208`	`}`
`209`	`209`	`}`
`@@ -217,7 +217,7 @@ public async Task CreateDailyAnchorsAsync(string userId, DateOnly date)`
`217`	`217`	`}`
`218`	`218`	`catch (Exception ex)`
`219`	`219`	`{`
`220`		`- logger.LogError(ex, "Failed to create daily anchors for {userId} on {date}", userId, date);`
	`220`	`+ logger.LogError(ex, "Failed to create daily anchors for {UserId} on {Date}", userId, date);`
`221`	`221`	`throw;`
`222`	`222`	`}`
`223`	`223`	`}`