Skip to content

Fix songrec timeouts#155

Open
Coquelicots wants to merge 1 commit into
snowarch:mainfrom
Coquelicots:patch-1
Open

Fix songrec timeouts#155
Coquelicots wants to merge 1 commit into
snowarch:mainfrom
Coquelicots:patch-1

Conversation

@Coquelicots

Copy link
Copy Markdown

Summary

When using Recognize music, the script would previously wait the full 30-second timeout even if the audio recording failed immediately (due to an invalid audio source)

Testing

  • inir restart && inir logs — no errors
  • Tested the specific feature path that changed
  • Both panel families checked (if shared code changed)

Updated the condition to check for track recognition instead of matches.
@snowarch snowarch moved this from Todo to In Progress in iNiR thing May 23, 2026
@snowarch snowarch self-assigned this May 23, 2026
@snowarch

Copy link
Copy Markdown
Owner

Thanks @Coquelicots — the PAREC_PID liveness guard is a genuine fix and I'd like to take it. Two asks:

  1. It no longer applies cleanly to current main/prerelease — needs a rebase.
  2. The match-condition change (from "matches": [ + length to a bare "track" grep) is a behavior change I'd rather not bundle with the timeout fix — could you drop that and keep just the early-exit guard?

Then I'll pull it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants