Skip to content

SNOW-1619616: Update Readme with information on Locale and JUnit tests (#1867) #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfc-gh-wfateem wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SNOW-1619616: Update Readme with information on Locale and JUnit tests (#1867) #2267

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6203c30
SNOW-1619616: Update Readme with information on Locale and JUnit test…
sfc-gh-wfateem Jul 16, 2025
cd0a2d4
Merge branch 'master' into SNOW-1619616-readme-update
sfc-gh-wfateem Jul 17, 2025
177f0f4
Merge branch 'master' into SNOW-1619616-readme-update
sfc-gh-wfateem Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,12 @@ Set the environment variables to specify the target database.
export SNOWFLAKE_TEST_WAREHOUSE=<your_warehouse>
export SNOWFLAKE_TEST_ROLE=<your_role>

Locale settings may cause some tests to fail unless you set the following:

.. code-block:: bash

export LC_ALL=C

@sfc-gh-rkowalski sfc-gh-rkowalski Jul 21, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to modify tests to make them locale agnostic instead?

@sfc-gh-wfateem sfc-gh-wfateem Jul 21, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-rkowalski my opinion is that the two don't have to be mutually exclusive. You can update the documentation today, since it's already a problem, until the tests are reviewed and modified to be locale agnostic.


Run the maven ``verify`` goal.

.. code-block:: bash
Expand Down