Skip to content

NO-SNOW: Add repo-local graphite-pr-workflow skill with mvn format + checkstyle pre-commit rules#2598

Merged
sfc-gh-dheyman merged 5 commits into
masterfrom
dheyman/add-graphite-skill
Apr 29, 2026
Merged

NO-SNOW: Add repo-local graphite-pr-workflow skill with mvn format + checkstyle pre-commit rules#2598
sfc-gh-dheyman merged 5 commits into
masterfrom
dheyman/add-graphite-skill

Conversation

@sfc-gh-dheyman

@sfc-gh-dheyman sfc-gh-dheyman commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Adds a Cursor skill at .cursor/skills/graphite-pr-workflow/SKILL.md that encodes the standard PR workflow for the snowflake-jdbc repository. The skill instructs the AI assistant to require explicit user approval before committing or submitting a PR, run the Spotify fmt plugin and checkstyle validation before any commit, follow the SNOW-{ticket}: commit message convention, prompt for a SNOW ticket number if one is not provided, detect stacked PR scenarios and use gt submit --stack accordingly, and use the standard PR description template with Summary, Context, and Test plan sections.

Copilot AI review requested due to automatic review settings April 23, 2026 18:25

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sfc-gh-dheyman sfc-gh-dheyman marked this pull request as ready for review April 23, 2026 18:26
@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner April 23, 2026 18:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a repo-local Cursor skill to standardize how contributors use Graphite CLI for creating branches/commits/PRs in snowflake-jdbc, including explicit “don’t commit/submit without instruction” guidance and required pre-commit Maven formatting/checkstyle steps.

Changes:

  • Introduces a new .cursor skill documenting the Graphite PR workflow for this repo.
  • Documents required pre-commit commands (Spotify fmt + check-style profile validation).
  • Provides commit message conventions and a PR description template.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .cursor/skills/graphite-pr-workflow/SKILL.md

sfc-gh-dheyman commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Apr 29, 7:51 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 29, 7:51 AM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 29, 8:21 AM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'AZURE Mac java 21 JDBC TestCategoryStatement,TestCategoryLoader', 'Jenkins', 'continuous-integration/jenkins/pr-merge').

…checkstyle pre-commit rules

Made-with: Cursor
@sfc-gh-dheyman sfc-gh-dheyman force-pushed the dheyman/add-graphite-skill branch from fc5a8ac to 8ff704b Compare April 29, 2026 07:51
Copilot AI review requested due to automatic review settings April 29, 2026 09:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .cursor/skills/graphite-pr-workflow/SKILL.md Outdated
Comment thread .cursor/skills/graphite-pr-workflow/SKILL.md
Comment thread .cursor/skills/graphite-pr-workflow/SKILL.md
Comment thread .cursor/skills/graphite-pr-workflow/SKILL.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 29, 2026 11:21
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .cursor/skills/graphite-pr-workflow/SKILL.md
@sfc-gh-dheyman sfc-gh-dheyman enabled auto-merge (squash) April 29, 2026 12:08
@sfc-gh-dheyman sfc-gh-dheyman merged commit 1f23b6b into master Apr 29, 2026
119 of 121 checks passed
@sfc-gh-dheyman sfc-gh-dheyman deleted the dheyman/add-graphite-skill branch April 29, 2026 13:07
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants