change uSUT tag to sut-stable#2606
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Jenkins CI pipeline configuration to use the sut-stable SUT tag/value for downstream JDBC test jobs.
Changes:
- Change the
svn_revisionbuild parameter value fromtemptest-deployedtosut-stablein the Jenkins pipeline job parameters.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
37df2b8 to
dfc2c6a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7bc2d6c to
5b434fa
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| string(name: 'PR_Key', value: scmInfo.GIT_BRANCH.substring(3)), | ||
| string(name: 'svn_revision', value: 'temptest-deployed') | ||
| string(name: 'svn_revision', value: 'sut-stable'), | ||
| string(name: 'node_label', value: 'regular_memory_node_snowos-snowos') |
There was a problem hiding this comment.
The new node_label parameter value (regular_memory_node_snowos-snowos) doesn’t match the label this pipeline actually runs on (regular_memory_node_snowos). If downstream jobs use node_label to select an executor, this mismatch is likely to send work to the wrong label or fail label resolution. Consider passing the same label string used by agent/node, or update all three places to a single shared constant if the -snowos suffix is intentional.
| string(name: 'node_label', value: 'regular_memory_node_snowos-snowos') | |
| string(name: 'node_label', value: 'regular_memory_node_snowos') |
5b434fa to
d2410a1
Compare
Overview
SNOW-XXXXX
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.