Skip to content

change uSUT tag to sut-stable#2606

Closed
sfc-gh-akolodziejczyk wants to merge 1 commit into
masterfrom
04-29-change_usut_tag_to_sut-stable
Closed

change uSUT tag to sut-stable#2606
sfc-gh-akolodziejczyk wants to merge 1 commit into
masterfrom
04-29-change_usut_tag_to_sut-stable

Conversation

@sfc-gh-akolodziejczyk

Copy link
Copy Markdown
Contributor

Overview

SNOW-XXXXX

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Copilot AI review requested due to automatic review settings April 29, 2026 09:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Jenkins CI pipeline configuration to use the sut-stable SUT tag/value for downstream JDBC test jobs.

Changes:

  • Change the svn_revision build parameter value from temptest-deployed to sut-stable in the Jenkins pipeline job parameters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk force-pushed the 04-29-change_usut_tag_to_sut-stable branch from 37df2b8 to dfc2c6a Compare April 29, 2026 11:47
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk marked this pull request as ready for review April 29, 2026 12:54
Copilot AI review requested due to automatic review settings April 29, 2026 12:54
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk requested a review from a team as a code owner April 29, 2026 12:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk force-pushed the 04-29-change_usut_tag_to_sut-stable branch 2 times, most recently from 7bc2d6c to 5b434fa Compare April 29, 2026 13:42
Copilot AI review requested due to automatic review settings April 29, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Jenkinsfile Outdated
string(name: 'PR_Key', value: scmInfo.GIT_BRANCH.substring(3)),
string(name: 'svn_revision', value: 'temptest-deployed')
string(name: 'svn_revision', value: 'sut-stable'),
string(name: 'node_label', value: 'regular_memory_node_snowos-snowos')

Copilot AI Apr 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new node_label parameter value (regular_memory_node_snowos-snowos) doesn’t match the label this pipeline actually runs on (regular_memory_node_snowos). If downstream jobs use node_label to select an executor, this mismatch is likely to send work to the wrong label or fail label resolution. Consider passing the same label string used by agent/node, or update all three places to a single shared constant if the -snowos suffix is intentional.

Suggested change
string(name: 'node_label', value: 'regular_memory_node_snowos-snowos')
string(name: 'node_label', value: 'regular_memory_node_snowos')

Copilot uses AI. Check for mistakes.
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk force-pushed the 04-29-change_usut_tag_to_sut-stable branch from 5b434fa to d2410a1 Compare April 29, 2026 13:48
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk deleted the 04-29-change_usut_tag_to_sut-stable branch April 30, 2026 09:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants