SNOW-2900795: Make MAX_BUFFER_SIZE in SnowflakeFileTranferAgent Configurable#2628
Open
XIIKJIIX wants to merge 1 commit into
Conversation
…r threshold - Added a new property `fileBackedBufferThreshold` to `UploadStreamConfig` to control the threshold in bytes at which the internal buffer switches from heap memory to a temporary file on disk during compression and digest computation. - Updated the builder pattern to include methods for setting and getting the buffer threshold, with validation for positive values. - Modified `SnowflakeConnectionImpl` and `SFBaseFileTransferAgent` to utilize the new buffer threshold in upload operations. - Introduced unit tests for `UploadStreamConfig` and `SnowflakeFileTransferConfig` to validate default and custom buffer threshold behavior, including edge cases for invalid values. - Updated relevant documentation and comments to reflect the new functionality. This change improves memory management during data uploads by allowing users to configure the buffer threshold, enhancing performance and stability.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-2900795: Github Issue #2443
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: SNOW-2900795: Make MAX_BUFFER_SIZE in SnowflakeFileTranferAgent Configurable #2443
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
This change improves memory management during data uploads by allowing users to configure the buffer threshold, enhancing performance and stability.
fileBackedBufferThresholdtoUploadStreamConfigto control the threshold in bytes at which the internal buffer switches from heap memory to a temporary file on disk during compression and digest computation.SnowflakeConnectionImplandSFBaseFileTransferAgentto utilize the new buffer threshold in upload operations.UploadStreamConfigandSnowflakeFileTransferConfigto validate default and custom buffer threshold behavior, including edge cases for invalid values.