Skip to content

feat: add more fileds to scaresult metadata#118

Open
mcombuechen wants to merge 1 commit intomainfrom
feature/more-metadata
Open

feat: add more fileds to scaresult metadata#118
mcombuechen wants to merge 1 commit intomainfrom
feature/more-metadata

Conversation

@mcombuechen
Copy link
Copy Markdown
Collaborator

@mcombuechen mcombuechen commented Feb 26, 2026

What this does

This adds fields for information that the uv plugin is currently emitting, to the ecosystems.SCAResult meta.

See here for the values that the uv plugin is currently emitting:

@mcombuechen mcombuechen requested a review from a team as a code owner February 26, 2026 10:52
@github-actions github-actions bot added the feat label Feb 26, 2026
@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Feb 26, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Runtime string `json:"runtime"`
TargetFile string `json:"targetFile"`
Runtime string `json:"runtime"`
ManifestFile string `json:"manifestFile"`
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is exactly the same as TargetFile. So maybe we don't need this to be separate.

TargetFile string `json:"targetFile"`
Runtime string `json:"runtime"`
ManifestFile string `json:"manifestFile"`
LockFile string `json:"lockfile"`
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make a distinction between the manifest and the lockfile. Relevant for other locked package managers in other ecosystems, too.

Runtime string `json:"runtime"`
ManifestFile string `json:"manifestFile"`
LockFile string `json:"lockfile"`
FileExclusions string `json:"fileExclusions"`
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want/need this; ideally some orchestrator outside of this plugin knows how to not throw two different plugins at the same pyproject.toml. Ideally the uv plugin would be agnostic to how it is being invoked alongside other plugins.

Maybe if we rename this to ProcessedFiles or ProcessedTargetFiles it would make more sense and it would be something that an orchestrator could pick up? Would this be a duplicate of TargetFile then?

@mcombuechen mcombuechen force-pushed the feature/more-metadata branch from 2bc8332 to 0435152 Compare February 26, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant