You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:
src/lib/plugins/get-multi-plugin-result.ts
⚠️
You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?
The early return implemented to support incomplete SBOMs triggers whenever allResults is empty, regardless of whether any actual failures occurred. If the CLI is run in a directory where no manifest files are detected (meaning both allResults and failedResults are empty), this change will cause the CLI to return a successful "empty" result instead of falling through to the existing error handling logic (line 196) which informs the user that no potential projects were found. This changes the default behavior for non-project directories from an error to a success when the flag is enabled. Consider adding a check for failedResults.length > 0.
The introduction of suppressWarnings silences all console output (on stderr) regarding dependency resolution failures when the --allow-incomplete-sbom flag is used. While the intention is to rely on annotations within the generated SBOM, silencing console.warn entirely deprives interactive users of immediate feedback about why their results are incomplete. Users may be confused by an "empty" success without seeing the underlying resolution errors that usually appear in the terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
What's the product update that needs to be communicated to CLI users?