You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Includes product update to be announced in the next stable release notes
What does this PR do?
Adds docker.io, xdg-utils, and uv to .circleci/Dockerfile so Linux acceptance jobs can rely on the build image instead of installing these during CircleCI. Does not change install-deps-linux-acceptance-tests or executor image tags yet — follow-up after Create Build Image publishes new tags.
Where should the reviewer start?
.circleci/Dockerfile — apt packages and uv install for the circleci user
How should this be manually tested?
After merge, run Create Build Image (workflow_dispatch) and confirm amd64/arm64 images build.
What's the product update that needs to be communicated to CLI users?
None — internal CI image only.
Risk assessment
Low — slightly larger image and longer build; no CLI behavior change until executor tags are updated.
The PR uses curl | sh to install uv from astral.sh. While common in CI, this pulls and executes an unverified remote script during the build process. If the domain or transport is compromised, malicious code could be injected into the build image.
The uv installation script is executed via curl | sh. Depending on the active USER in the Dockerfile at this point, the script might install to /root/.local/bin or /home/circleci/.local/bin. If it installs to root's home but the PATH is updated for circleci, the utility will not be found by the user running the tests. Explicitly setting the installation target or ensuring the correct USER is active is safer.
RUN curl -LsSf https://astral.sh/uv/install.sh | sh
ENV PATH=/home/circleci/.local/bin:$PATH
📚 Repository Context Analyzed
This review considered 5 relevant code sections from 3 files (average relevance: 0.73)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Adds
docker.io,xdg-utils, anduvto.circleci/Dockerfileso Linux acceptance jobs can rely on the build image instead of installing these during CircleCI. Does not changeinstall-deps-linux-acceptance-testsor executor image tags yet — follow-up after Create Build Image publishes new tags.Where should the reviewer start?
.circleci/Dockerfile— apt packages anduvinstall for thecircleciuserHow should this be manually tested?
What's the product update that needs to be communicated to CLI users?
None — internal CI image only.
Risk assessment
Low — slightly larger image and longer build; no CLI behavior change until executor tags are updated.
What are the relevant tickets?
CLI-1443