You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In getPrintGraphMode, the printGraphEnabled variable only checks for the base --print-graph flag and legacy aliases. It does not account for the new modular sub-flags --effective-graph, --jsonl-output, or --print-errors. Consequently, downstream predicates like shouldPrintEffectiveDepGraph will return false even if the user provides --effective-graph, unless they also explicitly provide the base --print-graph flag. This creates a regression in modular usability compared to the self-contained legacy flags.
The jsonlOutput property is calculated within getPrintGraphMode but is never consumed by any logic in the PR. The standard printDepGraph function remains hardcoded to output human-readable markers ('DepGraph data:', etc.) regardless of this flag. This makes the newly added --jsonl-output flag non-functional for standard dependency graphs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
What's the product update that needs to be communicated to CLI users?