fix: allow CLI extensions to opt in to self-documented help#6708
Draft
fix: allow CLI extensions to opt in to self-documented help#6708
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Allows CLI extensions to opt in to handling
--helpvia Cobra's flagset instead of TypeScript CLI's markdown-based help renderer.This is opt-in for now and each command would need to have the annotation added if they want to use the Cobra native help.
Context
Currently, all help is routed through the legacy CLI which reads markdown files from
help/cli-commands/and renders them with a custom TypeScript pipeline. This couples extension help to external docs and means extensions cannot keep their documentation close to and true to the source code. This also adds the overhead of having to coordinate simple things like flag releases with the docs team.This is a minimal, backwards-compatible change. Extensions opt in by adding a single annotation in the switch case in
createCommandsForWorkflows(). No changes togo-application-frameworkor individual extension repos are required.Extra considerations
TODO
Where should the reviewer start?
cliv2/cmd/cliv2/main.go— theprepareRootCommand()andcreateCommandsForWorkflows()functions.How should this be manually tested?
cd cliv2 && go build ./cmd/cliv2/snyk redteam --help— should render Cobra-generated help from the flagsetsnyk test --help— should still render the legacy markdown-based help (unchanged)Example
What's the product update that needs to be communicated to CLI users?
N/A
Risk assessment: Low
"self-documented"annotation