Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
acke
left a comment
acke
left a comment
There was a problem hiding this comment.
Must make unit tests pass before merge
ShawkyZ
changed the title
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
| logger.Warn().Err(err).Str(configuration.API_URL, urlString).Msg("failed to get api url") | ||
| } | ||
|
|
||
| if isValid, validationErr := auth.IsValidAuthHost(apiString, config.GetString(auth.CONFIG_KEY_ALLOWED_HOST_REGEXP)); !isValid || validationErr != nil { |
There was a problem hiding this comment.
nitpick: is a bit hard to understand.
pkg/local_workflows/connectivity_check_extension/connectivity_check_workflow_test.go
Outdated
Show resolved
Hide resolved
ShawkyZ
force-pushed
the
fix/IDE-1679-api-url-validation
branch
from
882b183 to
96d4ae4
Compare
| {"http://localhost:8080", true}, | ||
| {"https://127.0.0.1:9000", true}, | ||
| {"http://stella:8000", true}, | ||
| {"192.168.1.1", false}, |
There was a problem hiding this comment.
Issue: This is a breaking change.
There was a problem hiding this comment.
Fair,
Is there a reason why this is allowed ? Or just legacy reasons?
There was a problem hiding this comment.
So far there have been no restrictions on what API URLs users set. Technically this used for dev and test environments. Introducing a breaking change around the API URL has potentially high impact and needs to be explicitly decided and communicated.
PeterSchafer
left a comment
PeterSchafer
left a comment
There was a problem hiding this comment.
Just to avoid accidental merging.
4 participants
Validate API URL and Request URL against snyk.io or snykgov.io hostnames