Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
97a6eee to
f1804b3
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Adds
fingerprintsto the UFM SARIF output, per SARIF v2.1.0 section 3.27.16, to provide stable identifiers for results. Each result now includes two fingerprint entries:identityandsnyk/asset/finding/v1, both using the issue ID.Fingerprints are conditionally excluded for OSS issues (
scaandlicensefinding types) because their IDs are vulnerability/license identifiers rather than stable code-centric fingerprints suitable for result tracking.Where should the reviewer start?
internal/presenters/templates/ufm.sarif.tmpl– conditional fingerprint inclusion logicinternal/presenters/testdata/ufm/secrets.sarif.json– updated expected SARIF with fingerprints for non-OSS resultsHow should this be manually tested?
go test ./internal/presenters/ -run Test_UfmPresenter_Sarif -vWhat's the product update that needs to be communicated to CLI users?
None. This is an internal SARIF output enhancement for result management systems.
Risk assessment (Low | Medium | High)?
Low
What are the relevant tickets?
CLI-1328