Open
Conversation
This comment has been minimized.
This comment has been minimized.
parker-snyk
force-pushed
the
CN-934-tslint-to-eslint
branch
from
58c06dc to
ac092c7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The eslint migration accidentally removed the variable assignment for depGraph in a test that still uses it in assertions, causing a ReferenceError at runtime.
parker-snyk
force-pushed
the
CN-934-tslint-to-eslint
branch
from
d5436e1 to
7b88c17
Compare
This comment has been minimized.
This comment has been minimized.
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TSLint has been deprecated since 2019.
This PR migrates us to ESLint, which is still supported, and has more features and support
Any background context you want to provide?
This shouldn't have any downsteam effects for anyone using this library. It just lets us lint better and move faster for development on this project
What are the relevant tickets?
https://snyksec.atlassian.net/browse/CN-934
Screenshots