feat: ldx-sync provides product enablement and severity filter as booleans [IDE-1816]#1179
Open
andrewrobinsonhodges-snyk wants to merge 8 commits intorefactor/IDE-1786_folder-config-refactoringfrom
Conversation
andrewrobinsonhodges-snyk
had a problem deploying
to
MT1
GitHub Actions
Failure
andrewrobinsonhodges-snyk
had a problem deploying
to
Standard
GitHub Actions
Failure
andrewrobinsonhodges-snyk
had a problem deploying
to
MT3
GitHub Actions
Failure
This comment has been minimized.
This comment has been minimized.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…IDE-1816_split-products-and-filters
andrewrobinsonhodges-snyk
had a problem deploying
to
MT1
GitHub Actions
Failure
andrewrobinsonhodges-snyk
had a problem deploying
to
MT3
GitHub Actions
Failure
andrewrobinsonhodges-snyk
had a problem deploying
to
Standard
GitHub Actions
Failure
This comment has been minimized.
This comment has been minimized.
andrewrobinsonhodges-snyk
temporarily deployed
to
Standard
GitHub Actions
Inactive
andrewrobinsonhodges-snyk
temporarily deployed
to
MT1
GitHub Actions
Inactive
andrewrobinsonhodges-snyk
temporarily deployed
to
MT3
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
andrewrobinsonhodges-snyk
temporarily deployed
to
Standard
GitHub Actions
Inactive
andrewrobinsonhodges-snyk
temporarily deployed
to
MT1
GitHub Actions
Inactive
andrewrobinsonhodges-snyk
temporarily deployed
to
MT3
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
andrewrobinsonhodges-snyk
temporarily deployed
to
MT1
GitHub Actions
Inactive
andrewrobinsonhodges-snyk
temporarily deployed
to
Standard
GitHub Actions
Inactive
andrewrobinsonhodges-snyk
temporarily deployed
to
MT3
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
rrama
reviewed
Apr 7, 2026
| SettingScanAutomatic: "scan_automatic", | ||
| SettingScanNetNew: "scan_net_new", | ||
| SettingIssueViewOpenIssues: "issue_view_open_issues", | ||
| SettingIssueViewIgnoredIssues: "issue_view_ignored_issues", |
Contributor
There was a problem hiding this comment.
Q: Why is this not done in a map like the severity filters below?
Collaborator
There was a problem hiding this comment.
why do we need a map actually and not check for the prop names directly ?
…IDE-1816_split-products-and-filters
andrewrobinsonhodges-snyk
temporarily deployed
to
MT3
GitHub Actions
Inactive
andrewrobinsonhodges-snyk
temporarily deployed
to
MT1
GitHub Actions
Inactive
andrewrobinsonhodges-snyk
temporarily deployed
to
Standard
GitHub Actions
Inactive
The AnnotationRemoteKey annotations in register_configurations.go used incorrect keys that didn't match the actual LDX-Sync API field names. This caused the GAF ConfigResolver to fail mapping remote config keys. Changes: - severities -> removed (severities now handled via severityAPIKeys) - cwe -> cwe_ids - cve -> cve_ids - rule -> rule_ids - automatic -> scan_automatic - net_new -> scan_net_new - open_issues -> issue_view_open_issues - ignored_issues -> issue_view_ignored_issues - Added AnnotationRemoteKey for product settings (product_code_enabled, etc.)
nick-y-snyk
force-pushed
the
feat/IDE-1816_split-products-and-filters
branch
from
860eb86 to
100125f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
andrewrobinsonhodges-snyk
temporarily deployed
to
Standard
GitHub Actions
Inactive
andrewrobinsonhodges-snyk
temporarily deployed
to
MT3
GitHub Actions
Inactive
andrewrobinsonhodges-snyk
temporarily deployed
to
MT1
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
make generate)make lint-fix)