Draft
Conversation
* fix: send diagnostics for all products This is because if both Secrets and Code have diagnostics for a file they would wipe the diagnostics for the other with their notification. * test: new product diag combine logic * fix: only send diags for files product touched * refactor: map more efficiently * chore: better Folder mutexing Remove useless mutexing around sync maps. Add seperate mutexing for the status and diagnostics manipulation/publishing to prevent races. * fix: clear secrets issue cache properly * fix: err if secrets FF is disabled * fix: revert mutexes * fix: revert extra publish call * chore: format * fix: post scan handler * fix: test expectation * fix: affectedFilePath for secrets * fix: issue caching * chore: refactor interface * fix: tests * chore: renames * refactor: postAction func --------- Co-authored-by: Abdelrahman Shawki Hassan <shawki.hassan@snyk.io>
* fix: Update alignment of html settings page. Update section titles * fix: tooltips now have info icons * fix: hide pre/post scan commands, improve tooltips * fix: update settings fallback to match style of main settings page * fix: remove tests for disabled pre/post scan commands * fix: code review feedback - fix tests and tooltip alignment
* fix: less FC gets for scan agg Plus only get an immutable folder config. This will help increase performance. Removed internal helpers from the interface and test `StateSnapshot()`. * fix: get FCs less for scan aggregator Also don't enrich from git when getting feature flags, which is a hot path. * fix: ensure scan summary always is updated at end of scans * fix: don't enrich from Git when immutable FC Shawky told me to do it! Plus remove `CreateMinimalFCOnErr` and just rely on `CreateIfNotExist` to be simpler. * fix: don't reset scan agg back to 0 anymore It was breaking single file scans and failing tests. * fix: less enriching from Git Make more immutable folder configs. * refactor: just use immutable FC for FFs * refactor: use immutable FC for scan agg again * fix: always use global fallback for configs * fix: html setting for issueviewoption --------- Co-authored-by: Abdelrahman Shawki Hassan <shawki.hassan@snyk.io>
…#1188) * fix: eliminate redundant delta recomputations in diagnostics hot path Move delta computation (disk I/O + fuzzy matching) from the diagnostics publishing hot path to post-scan time. Previously, every config change triggered ~64 GetDelta calls (4 products × 4 FilterAndPublishDiagnostics × 4 filterIssuesWithConfig), each doing full baseline disk reads and fuzzy matching under an exclusive mutex. Now, enrichCachedIssuesWithDelta runs once in postScanAction after all scans complete (baselines available), stamping IsNew on cached issue pointers in-place. The hot path (filterIssuesWithConfig) and summary HTML just filter by the pre-computed IsNew flag. - Add enrichCachedIssuesWithDelta: runs delta once, mutates cached issues - Add filterByIsNew: cheap boolean filter replacing GetDeltaForAllProducts - Simplify GetDelta/GetDeltaForAllProducts to filter by IsNew flag - Remove exclusive mutex from GetDelta (no longer does expensive work) - Summary HTML derives delta issues from cached IsNew flags
…86_folder-config-refactoring
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
rrama
changed the base branch from
refactor/IDE-1786_folder-config-refactoring
to
tmp/76380d0
…/IDE-1786_folder-config-refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
make generate)make lint-fix)