feat: [CN-296] Support Container Base Image Recommendations#991
Draft
dan-arpino wants to merge 1 commit intomainfrom
Draft
feat: [CN-296] Support Container Base Image Recommendations#991dan-arpino wants to merge 1 commit intomainfrom
dan-arpino wants to merge 1 commit intomainfrom
Conversation
|
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| agg.referenceScanStates[folderProductKey{Product: product.ProductOpenSource, FolderPath: folderPath}] = &scanState{Status: NotStarted} | ||
| agg.referenceScanStates[folderProductKey{Product: product.ProductCode, FolderPath: folderPath}] = &scanState{Status: NotStarted} | ||
| agg.referenceScanStates[folderProductKey{Product: product.ProductInfrastructureAsCode, FolderPath: folderPath}] = &scanState{Status: NotStarted} | ||
| agg.referenceScanStates[folderProductKey{Product: product.ProductContainer, FolderPath: folderPath}] = &scanState{Status: NotStarted} |
Collaborator
There was a problem hiding this comment.
Does your implementation support delta scanning? If not, this probably needs a revision.
Collaborator
There was a problem hiding this comment.
The whole API client functionality should be a workflow in https://github.com/snyk/go-application-framework and used / imported here. That would enable re-use in the CLI and migration away from the legacy CLI functionality through using a go-workflow.
| } | ||
|
|
||
| codeAction, err := snyk.NewCodeAction( | ||
| fmt.Sprintf("Upgrade to %s", recommendation.RecommendedImage), |
Collaborator
There was a problem hiding this comment.
We may want to add (Snyk) at the end of the action title.
Collaborator
There was a problem hiding this comment.
Also, in Open Source, we add the number of issues that would be fixed, and the number of issues that would remain in the text. Having that for container, would be great!
dan-arpino
force-pushed
the
feat/CN-296-container-base-image-rec
branch
from
380b07d to
701895d
Compare
dan-arpino
force-pushed
the
feat/CN-296-container-base-image-rec
branch
from
701895d to
38fe982
Compare
dan-arpino
force-pushed
the
feat/CN-296-container-base-image-rec
branch
from
38fe982 to
9052808
Compare
dan-arpino
force-pushed
the
feat/CN-296-container-base-image-rec
branch
from
9052808 to
aa527af
Compare
dan-arpino
force-pushed
the
feat/CN-296-container-base-image-rec
branch
from
aa527af to
20b48fd
Compare
dan-arpino
force-pushed
the
feat/CN-296-container-base-image-rec
branch
from
20b48fd to
18f175f
Compare
dan-arpino
force-pushed
the
feat/CN-296-container-base-image-rec
branch
from
18f175f to
1c3ba84
Compare
dan-arpino
force-pushed
the
feat/CN-296-container-base-image-rec
branch
from
1c3ba84 to
e0c1ab5
Compare
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
Adding a new Container LS to support the upgrading the container base images in a docker file.
dan-arpino
force-pushed
the
feat/CN-296-container-base-image-rec
branch
from
e0c1ab5 to
39df9da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new Container LS to support the upgrading the container base images in a docker file.
Description
Adding base image recommendations to the IDE. This will scan docker files for base images and check if we have any base image upgrade recommendations CN-296
Checklist
make generate)make lint-fix)