Fix grpc-status sent as initial header instead of trailer.#1
Merged
samuel-williams-shopify merged 3 commits intoMar 10, 2026
Merged
Conversation
When a gRPC response includes a body, grpc-status must be sent as an HTTP/2 trailing HEADERS frame. However, invoke_service was adding grpc-status to response.headers before send_response called trailer!, causing it to be included in the initial headers instead of trailers. Call trailer! at the start of invoke_service to mark the header position. Since trailer! uses ||= for @tail, the subsequent call in send_response is a no-op, and any headers added after our call (including grpc-status) are correctly positioned as trailers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
samuel-williams-shopify
force-pushed
the
fix-grpc-trailer-headers
branch
from
f97c7bd to
d9a1e1d
Compare
samuel-williams-shopify
merged commit 7636f9a
into
socketry:main
16 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a gRPC response includes a body, grpc-status must be sent as an HTTP/2 trailing HEADERS frame. However, invoke_service was adding grpc-status to response.headers before send_response called trailer!, causing it to be included in the initial headers instead of trailers.
Call trailer! at the start of invoke_service to mark the header position. Since trailer! uses ||= for @tail, the subsequent call in send_response is a no-op, and any headers added after our call (including grpc-status) are correctly positioned as trailers.