refactor: remove hybridlogstorage#1201
Merged
Merged
Conversation
Contributor
|
Warning Rate limit exceeded@fengjiachun has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 21 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis change removes the entire Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Build as Maven Build
participant Project as Project Structure
Dev->>Build: Remove java-log-storage-impl module from parent POM
Dev->>Project: Delete all java-log-storage-impl source, test, and resource files
Dev->>Build: Update root pom.xml (Java 17, plugins, dependencies)
Build->>Project: Build proceeds without java-log-storage-impl
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
pom.xml (1)
108-112: Stale dependency – removed module will now resolve to nothing
java-log-storage-implwas deleted but is still declared in<dependencyManagement>. Any sub-module that lists it as a dependency will fail with artifact not found.- <dependency> - <groupId>${project.groupId}</groupId> - <artifactId>java-log-storage-impl</artifactId> - <version>${project.version}</version> - </dependency>Remove this block (and any usages) to keep the build green.
🧹 Nitpick comments (2)
pom.xml (2)
340-347: Use the<release>flag for cleaner byte-code targeting
With compiler-plugin 3.11 you can simplify:-<source>${java.source.version}</source> -<target>${java.target.version}</target> +<release>${java.source.version}</release>This guarantees a single-pass compile and avoids inconsistencies between
-source/-target.
362-363: Surefire 3.0.0-M9 is still a milestone
A stable 3.2.x line is available and fixes several JPMS issues. Consider upgrading to a non-milestone release to reduce future maintenance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (52)
jraft-extension/java-log-storage-impl/pom.xml(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/core/HybridLogJRaftServiceFactory.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/option/StoreOptions.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/HybridLogStorage.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/LogitLogStorage.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/db/AbstractDB.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/db/ConfDB.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/db/IndexDB.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/db/SegmentLogDB.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/factory/LogStoreFactory.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/AbstractFile.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/FileHeader.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/FileManager.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/FileType.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/assit/AbortFile.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/assit/Checkpoint.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/assit/FirstLogIndexCheckpoint.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/assit/FlushStatusCheckpoint.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/assit/HybridStorageStatusCheckpoint.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/index/IndexFile.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/index/IndexType.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/segment/SegmentFile.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/service/AllocateFileService.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/service/ServiceManager.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/util/Pair.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/util/Platform.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/util/concurrent/ReferenceResource.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/util/concurrent/ShutdownAbleThread.java(0 hunks)jraft-extension/java-log-storage-impl/src/main/resources/META-INF/services/com.alipay.sofa.jraft.JRaftServiceFactory(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/CliServiceTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/ExpectClosure.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/MockClosure.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/MockStateMachine.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/TestCluster.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/TestJRaftServiceFactory.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/V1JRaftServiceFactory.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/BaseLogStorageTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/BaseStorageTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/Benchmark/BaseLogStorageBenchmark.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/Benchmark/DefaultLogStorageBenchmark.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/Benchmark/JmhBenchmark.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/HybridLogStorageTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/LogitLogStorageTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/db/ConfDBTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/db/IndexDBTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/db/SegmentLogDBTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/file/FileManagerTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/file/index/IndexFileTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/file/segment/SegmentFileTest.java(0 hunks)jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/test/TestUtils.java(0 hunks)jraft-extension/pom.xml(0 hunks)pom.xml(3 hunks)
💤 Files with no reviewable changes (51)
- jraft-extension/pom.xml
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/ExpectClosure.java
- jraft-extension/java-log-storage-impl/src/main/resources/META-INF/services/com.alipay.sofa.jraft.JRaftServiceFactory
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/MockClosure.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/db/ConfDB.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/TestJRaftServiceFactory.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/db/SegmentLogDB.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/index/IndexType.java
- jraft-extension/java-log-storage-impl/pom.xml
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/V1JRaftServiceFactory.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/assit/Checkpoint.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/core/HybridLogJRaftServiceFactory.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/assit/HybridStorageStatusCheckpoint.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/util/concurrent/ShutdownAbleThread.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/FileHeader.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/service/ServiceManager.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/file/segment/SegmentFileTest.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/assit/FlushStatusCheckpoint.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/util/concurrent/ReferenceResource.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/file/FileManagerTest.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/MockStateMachine.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/HybridLogStorageTest.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/FileType.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/util/Platform.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/assit/FirstLogIndexCheckpoint.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/Benchmark/DefaultLogStorageBenchmark.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/util/Pair.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/test/TestUtils.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/assit/AbortFile.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/db/ConfDBTest.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/service/AllocateFileService.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/Benchmark/JmhBenchmark.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/BaseStorageTest.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/BaseLogStorageTest.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/db/IndexDBTest.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/Benchmark/BaseLogStorageBenchmark.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/LogitLogStorage.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/segment/SegmentFile.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/db/IndexDB.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/db/SegmentLogDBTest.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/CliServiceTest.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/core/TestCluster.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/index/IndexFile.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/option/StoreOptions.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/factory/LogStoreFactory.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/HybridLogStorage.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/file/index/IndexFileTest.java
- jraft-extension/java-log-storage-impl/src/test/java/com/alipay/sofa/jraft/storage/LogitLogStorageTest.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/FileManager.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/db/AbstractDB.java
- jraft-extension/java-log-storage-impl/src/main/java/com/alipay/sofa/jraft/storage/file/AbstractFile.java
🧰 Additional context used
🪛 GitHub Actions: build
pom.xml
[error] 1-1: Maven compile error: Fatal error compiling: invalid target release: 17. The project is configured to compile with target release 17, but the Java version used is 1.8.0_452.
[warning] 87-87: Maven warning: 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-jar-plugin is missing. This may threaten build stability.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: sca
🔇 Additional comments (2)
pom.xml (2)
62-63: Switching to Java 17 breaks the current CI setup
mvnnow compiles with--release 17, while the pipeline still runs on JDK 8 (see build failure). Make sure the GitHub Actions matrix (or any other build infra) is updated tojdk: 17before merging, otherwise every downstream build will keep failing.
66-66: JNA 5.14.0 bump looks good – no concerns.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
.github/workflows/build.yml (1)
82-95:test_storage_java_impljob is now dead code after removingjava-log-storage-implThe PR deletes the entire
jraft-extension/java-log-storage-implmodule, yet this job still tries to build & test it.
Remaining as-is will cause the workflow to fail with a Maven “unknown module” error on the first push tomaster.Two quick fixes:
- test_storage_java_impl: - needs: check_format - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - name: Set up JDK 17 - uses: actions/setup-java@v1 - with: - java-version: 17 - - name: Maven Test - run: mvn clean install -DskipTests=true -Dmaven.javadoc.skip=true -B -V - && (mvn --projects jraft-extension/java-log-storage-impl test - || mvn --projects jraft-extension/java-log-storage-impl test - || mvn --projects jraft-extension/java-log-storage-impl test) + # Removed because module was deleted in PR #1201or, if you still need storage tests, point the job at the surviving storage module.
Failing to address this will break CI on merge.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build.yml(6 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/build.yml
15-15: the runner of "actions/setup-java@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
28-28: the runner of "actions/setup-java@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
43-43: the runner of "actions/setup-java@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
58-58: the runner of "actions/setup-java@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
73-73: the runner of "actions/setup-java@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
88-88: the runner of "actions/setup-java@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: test_storage_java_impl
- GitHub Check: test_rpc_grpc_impl
- GitHub Check: test_rheakv_pd
- GitHub Check: test_rheakv_core
- GitHub Check: test_jraft_core
- GitHub Check: sca
fengjiachun
force-pushed
the
refacor/remove-hybridlogstorage
branch
from
45ac167 to
fd52d3a
Compare
fengjiachun
force-pushed
the
refacor/remove-hybridlogstorage
branch
from
fd52d3a to
dee1bf2
Compare
killme2008
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
And bump JNA to 5.14
close #914
and it is part of #1175
If there is no issue then describe the changes introduced by this PR.
Summary by CodeRabbit
Summary by CodeRabbit