fix(iOS, SplitView): Override the frame with HostView bounds in collapsed mode#3811
Draft
fix(iOS, SplitView): Override the frame with HostView bounds in collapsed mode#3811
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an iOS UISplitViewController collapsed-mode layout issue where navigating back to an off-screen supplementary column can render with a stale (too narrow) width by overriding the frame used for ShadowTree updates.
Changes:
- Resolve the SplitHost controller/view via
guardand early-return on failure. - Compute a
targetFrameand, when collapsed, use the host view’s bounds as the intended full-width frame. - Pass the computed frame into the
ShadowStateProxyupdate call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kligarski
reviewed
Mar 31, 2026
Contributor
kligarski
left a comment
There was a problem hiding this comment.
The code looks good but I found this bug:
Simulator.Screen.Recording.-.iPad.Pro.13-inch.M5.-.2026-03-31.at.12.00.10.mov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Navigating back to a supplementary column while the
UISplitViewControllerwas collapsed caused the column to render with an incorrect frame. When aUISplitViewControlleris collapsed, it pushes its columns onto a singleUINavigationControllerstack, butUIKitdoes not update the frame of off-screen views immediately. Therefore, a hidden supplementary column retains its old width.If the SplitView is currently collapsed, we know the column must eventually span the entire screen. We extract the Host's bounds and pass them as the target frame directly to the
ShadowStateProxy.Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1089
Changes
Before & after - visual documentation
before.mov
after.mov
Test plan
No need to have a dedicated test, reproducible on any existing.
Checklist