refactor(tests): test-tabs-tab-bar-more-navigation-controller + scenario#3861
Open
refactor(tests): test-tabs-tab-bar-more-navigation-controller + scenario#3861
Conversation
…ns into @lkuchno/test-tabs-tab-bar-more-navigation-controller
kkafar
reviewed
Apr 10, 2026
Member
kkafar
left a comment
There was a problem hiding this comment.
I have few remarks. Let's resolve them before proceeding.
I have also a remark regarding naming. I think that more navigation controller has a broader scope than just tab bar, therefore I think that this rename is unnecessary here. What do you think?
Member
There was a problem hiding this comment.
I think we could add here test flows with resizing the app on iPad.
There is at least one more behaviour worth documenting.
When more navigation controller is selected on iPad (More list), and we resize the app, so that the "bottom tab bar" disappears, the previously selected tab is selected.
It would be ideal if we also were able to test navigation state updates in such case. Let's talk about this.
…ns into @lkuchno/test-tabs-tab-bar-more-navigation-controller
…ns into @lkuchno/test-tabs-tab-bar-more-navigation-controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moving test-tabs-tab-bar-more-navigation-controller into separate directory with scenario to it.
Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1120
Changes
- moving between More tab screen + tabs in it and tabs visible in tab bar normally,
- check on navigation using buttons directly navigate to tabs and moretab screen
- quick check on iPad when More tab is not displayed