Skip to content

refactor(tests): test-tabs-tab-bar-more-navigation-controller + scenario#3861

Open
LKuchno wants to merge 11 commits intomainfrom
@lkuchno/test-tabs-tab-bar-more-navigation-controller
Open

refactor(tests): test-tabs-tab-bar-more-navigation-controller + scenario#3861
LKuchno wants to merge 11 commits intomainfrom
@lkuchno/test-tabs-tab-bar-more-navigation-controller

Conversation

@LKuchno
Copy link
Copy Markdown
Collaborator

@LKuchno LKuchno commented Apr 9, 2026

Description

Moving test-tabs-tab-bar-more-navigation-controller into separate directory with scenario to it.

Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1120

Changes

  • Screen moved into a new directory with a corresponding name, extended with '-tab-bar-'
  • New manual scenario created in the same directory covering different paths:
    - moving between More tab screen + tabs in it and tabs visible in tab bar normally,
    - check on navigation using buttons directly navigate to tabs and moretab screen
    - quick check on iPad when More tab is not displayed

@LKuchno LKuchno added the area:tabs Issue related to bottom tabs label Apr 9, 2026
Copy link
Copy Markdown
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few remarks. Let's resolve them before proceeding.

I have also a remark regarding naming. I think that more navigation controller has a broader scope than just tab bar, therefore I think that this rename is unnecessary here. What do you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add here test flows with resizing the app on iPad.

There is at least one more behaviour worth documenting.

When more navigation controller is selected on iPad (More list), and we resize the app, so that the "bottom tab bar" disappears, the previously selected tab is selected.

It would be ideal if we also were able to test navigation state updates in such case. Let's talk about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tabs Issue related to bottom tabs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants