fix: polish mobile Solana data dashboard#1596
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
Greptile SummaryThis PR replaces a hardcoded provider list with one derived dynamically from SQL row data, and polishes the mobile layout of the data dashboard and its charts.
Confidence Score: 5/5Safe to merge; changes are additive UI/layout polish with a well-tested provider-derivation refactor that correctly handles pre-load, empty, and legacy-alias states. All provider state flows correctly through the new dynamic derivation path — pre-load (empty availableProviders), post-load, URL round-trips, legacy alias normalization, and unknown-provider fallback are all tested. The KPI grid border logic is correct across all three breakpoints. The compact chart margin change is a targeted layout improvement with no broken rendering paths. No files require special attention, though the compact chart left margin (52 px) is worth a quick visual confirmation against the PR description's claim of increased label space. Important Files Changed
Reviews (2): Last reviewed commit: "fix: address data dashboard review feedb..." | Re-trigger Greptile |
|
Addressed the Greptile review notes in
Verification:
|
Problem
The Solana data dashboard needed mobile polish: the KPI summary was too dense on phone widths, and compact chart y-axis labels could clip on transaction-count charts. The branch also tightens dashboard provider/data handling so chart and KPI state is derived more consistently.
Summary of Changes
300Mare not clipped.No linked issue.
Change classification (SDLC §2)
security gates, or anything that changes who can do what
changes, dependency updates, monitoring/config)
Security checklist
(use Doppler /
NEXT_PUBLIC_*only for values safe to ship to thebrowser).
dangerouslySetInnerHTML/ unsanitized HTML on untrusted input.pnpm auditpasses (no new High/Critical advisories).
included below, and a second reviewer has been requested.
New dependencies: none.
Threat-model note for Critical changes: n/a.
Verification
pnpm --dir apps/web exec eslint 'src/app/[locale]/data/solana-data-dashboard.tsx'pnpm --dir apps/web exec eslint 'src/app/[locale]/data/time-series-chart.tsx'pnpm -w exec prettier --ignore-path .prettierignore --check 'apps/web/src/app/[locale]/data/solana-data-dashboard.tsx'pnpm -w exec prettier --ignore-path .prettierignore --check 'apps/web/src/app/[locale]/data/time-series-chart.tsx'390x844with stubbed dashboard data for KPI stacking and transaction-count y-axis clipping.