Skip to content

docs: avoid wallet adapter legacy bundle#1666

Open
h4rkl wants to merge 1 commit into
mainfrom
codex/issue-396-wallet-adapter-deps
Open

docs: avoid wallet adapter legacy bundle#1666
h4rkl wants to merge 1 commit into
mainfrom
codex/issue-396-wallet-adapter-deps

Conversation

@h4rkl

@h4rkl h4rkl commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the unused @solana/wallet-adapter-wallets package from the React wallet cookbook install command
  • add a note explaining that the example uses Wallet Standard discovery with wallets={[]}
  • point users who specifically need WalletConnect protocol support to Reown's Solana Adapter docs

Validation

  • pnpm --filter solana-docs lint
  • curl -I -L https://solana.com/developers/guides/wallets/add-solana-wallet-adapter-to-nextjs returns 308 to /developers/cookbook/wallets/connect-wallet-react, then 200
  • curl -I -L https://docs.reown.com/advanced/providers/solana-adapter returns 200
  • Playwright against local http://localhost:3003/developers/cookbook/wallets/connect-wallet-react: HTTP 200, no console/page errors, no horizontal overflow; install snippet omits @solana/wallet-adapter-wallets and Reown link is present

Fixes #396

@h4rkl h4rkl requested review from ZYJLiu and jacobcreech as code owners July 9, 2026 02:25
@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solana-com-docs Ready Ready Preview, Comment Jul 9, 2026 2:28am
5 Skipped Deployments
Project Deployment Actions Updated (UTC)
solana-com Skipped Skipped Jul 9, 2026 2:28am
solana-com-accelerate Skipped Skipped Jul 9, 2026 2:28am
solana-com-breakpoint-2 Skipped Skipped Jul 9, 2026 2:28am
solana-com-media Skipped Skipped Jul 9, 2026 2:28am
templates Skipped Skipped Jul 9, 2026 2:28am

Request Review

@greptile-apps

greptile-apps Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the "Connect a Wallet with React" cookbook page to remove the unused @solana/wallet-adapter-wallets package from the install command and adds an informational callout explaining the rationale.

  • Removes @solana/wallet-adapter-wallets from the npm install snippet, since the example already uses wallets={[]} (Wallet Standard discovery) and does not require the legacy bundle.
  • Adds a <Callout> clarifying the Wallet Standard discovery approach and directing users who need WalletConnect protocol support to Reown's Solana Adapter docs.

Confidence Score: 5/5

Documentation-only change that removes an unused package from an install command and adds an informational callout; no runtime code is modified.

The removed package (@solana/wallet-adapter-wallets) was already unused — the code example uses wallets={[]} for Wallet Standard discovery, so dropping it from the install snippet is accurate. The new callout correctly explains the design choice and links to an alternative for users who need WalletConnect support. The external URL (docs.reown.com/advanced/providers/solana-adapter) was validated in the PR description. Nothing about this change can break runtime behaviour.

No files require special attention.

Important Files Changed

Filename Overview
apps/docs/content/cookbook/wallets/connect-wallet-react.mdx Removes @solana/wallet-adapter-wallets from the install command and adds a callout explaining the Wallet Standard discovery approach; consistent with the wallets={[]} usage in the code example.

Reviews (1): Last reviewed commit: "docs: avoid wallet adapter legacy bundle" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wallet connect now deprecated

1 participant