Migrate navigation from Bootstrap to Radix UI#712
Closed
GuiBibeau wants to merge 19 commits into
Closed
Conversation
|
@GuiBibeau is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
- Add alignOffset to shift dropdowns 30px to the left - Improves visual alignment for right-side menu items
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Rename HeaderNew to Header for consistency - Move conditional logic into component body - Extract showDevelopersNav variable for clarity
- Change from named import to default import for solanaPreset - Add future property to prevent PostCSS errors - Clean up debug code
- Add .nvmrc file with Node 22 - Add engines field to package.json requiring Node >=22.0.0 - Ensures CI and local development use compatible Node version
- Create test-formatting workflow using Node 22 - Keep Node 22 requirement in package.json and .nvmrc - Use actions/setup-node@v4 which supports Node 22
- Add CI workflow for formatting, linting, and building - Use node-version-file to read from .nvmrc - Ensures all CI jobs use Node 22 consistently - Fixes cheerio compatibility issue (requires Node >=20.18.1)
Define NODE_VERSION once as an environment variable to avoid duplication. Both jobs now reference the same version (22) via env.NODE_VERSION.
- Add override modifiers to React component lifecycle methods in token-transitions.client.tsx - Add explicit return type to useInkeepConfig function to resolve external module type naming issue - Add isThemePage property to ThemeContext initial value for type consistency - Add type guard for string check before calling replace method in MarkdownImage component
Collaborator
|
We need to migrate the header and footer at the same time. There's a PR in progress here #704 with most of the Footer work done if you want to merge it in to this work. |
- Add universities landing page and components - Add universities link to navigation dropdown in Learn section - Resolve merge conflicts with deleted header files
- Remove globals.css file with duplicate Tailwind base/components/utilities - Remove CSS import from index.ts - Fixes fumadocs rendering issue caused by style conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The existing navigation component uses Bootstrap which is inconsistent with the modern UI component architecture. The navigation needs to be migrated to use Radix UI components for better maintainability and consistency.
Summary of Changes