Skip to content

Ability to render Dialog without portal#12

Merged
sergeyzwezdin merged 2 commits into
mainfrom
fix/portalless-dialog
Jun 9, 2025
Merged

Ability to render Dialog without portal#12
sergeyzwezdin merged 2 commits into
mainfrom
fix/portalless-dialog

Conversation

@sergeyzwezdin

@sergeyzwezdin sergeyzwezdin commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

Description

Ability to render Dialog without portal.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Lint and prettier checks pass locally
  • I run the changeset and updated versions of the packages and repository (if applicable)

This comment was marked as outdated.

@sergeyzwezdin sergeyzwezdin requested a review from Copilot June 9, 2025 13:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new feature allowing the Dialog component to be rendered without being wrapped in a portal.

  • Added an optional "renderPortal" prop to the DialogContent component.
  • Updated the version in package.json and CHANGELOG.md to document this new behavior.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/ui/src/components/dialog.tsx Added "renderPortal" prop and conditional rendering logic for DialogContent.
packages/ui/package.json Bumped version to 0.9.0 to reflect the new feature.
packages/ui/CHANGELOG.md Documented the new behavior in the changelog.
Comments suppressed due to low confidence (1)

packages/ui/src/components/dialog.tsx:41

  • Consider adding a brief inline comment or JSDoc for the 'renderPortal' prop to clarify its purpose and usage for future maintainers.
renderPortal = true,

@sergeyzwezdin sergeyzwezdin merged commit dcb9679 into main Jun 9, 2025
2 checks passed
@sergeyzwezdin sergeyzwezdin deleted the fix/portalless-dialog branch June 9, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants