Ability to render Dialog without portal#12
Merged
Conversation
nchigryay
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new feature allowing the Dialog component to be rendered without being wrapped in a portal.
- Added an optional "renderPortal" prop to the DialogContent component.
- Updated the version in package.json and CHANGELOG.md to document this new behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui/src/components/dialog.tsx | Added "renderPortal" prop and conditional rendering logic for DialogContent. |
| packages/ui/package.json | Bumped version to 0.9.0 to reflect the new feature. |
| packages/ui/CHANGELOG.md | Documented the new behavior in the changelog. |
Comments suppressed due to low confidence (1)
packages/ui/src/components/dialog.tsx:41
- Consider adding a brief inline comment or JSDoc for the 'renderPortal' prop to clarify its purpose and usage for future maintainers.
renderPortal = true,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ability to render
Dialogwithout portal.Type of change
Checklist