Skip to content

Fix signTransaction feature typo #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Michaelsulistio wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix signTransaction feature typo #1366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4ebac9
Fix signTransaction feature typo
Michaelsulistio Jan 13, 2026
0fd20fe
Add additional, out-of-spec, check for signTransactions string constant
Michaelsulistio Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/packages/wallet-standard-mobile/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@solana-mobile/wallet-standard-mobile",
"description": "A wallet-standard wallet for mobile wallet apps that conform to the Solana Mobile Wallet Adapter protocol",
"version": "0.4.4",
"version": "0.4.4-hotfix.0",
"author": "Marco Martinez <marco.martinez@solana.com>",
"repository": "https://github.com/solana-mobile/mobile-wallet-adapter",
"license": "Apache-2.0",
Expand Down
4 changes: 2 additions & 2 deletions js/packages/wallet-standard-mobile/src/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ export class LocalSolanaMobileWalletAdapterWallet implements SolanaMobileWalletA
capabilities: Awaited<ReturnType<GetCapabilitiesAPI['getCapabilities']>>
) => {
// TODO: investigate why using SolanaSignTransactions constant breaks treeshaking
const supportsSignTransaction = capabilities.features.includes('solana:signTransactions');//SolanaSignTransactions);
Copy link
Copy Markdown
Collaborator

@Funkatronics Funkatronics Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change will break MWA 2.0 compliant wallets. the specified identifier is solana:signTransactions. that value must be checked. If we need a translation for misbehaving wallets that are hard coding an incorrect identifier we can do that, but there is a better layer for that.

Copy link
Copy Markdown
Collaborator Author

@Michaelsulistio Michaelsulistio Jan 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh good catch, I had assumed the strings were matched between MWA and Wallet Standard features because that's what Seed Vault Wallet was returning:

This is what SVW is returning in capabilities:
telegram-cloud-photo-size-1-5130031525758962753-y

Seems like the fix is that SVW actually needs to return the correct string solana:signTransactions (plural)

const supportsSignTransaction = capabilities.features.includes('solana:signTransaction') || capabilities.features.includes('solana:signTransactions');//SolanaSignTransactions);
const supportsSignAndSendTransaction = capabilities.supports_sign_and_send_transactions;
const didCapabilitiesChange =
SolanaSignAndSendTransaction in this.features !== supportsSignAndSendTransaction ||
Expand Down Expand Up @@ -751,7 +751,7 @@ export class RemoteSolanaMobileWalletAdapterWallet implements SolanaMobileWallet
capabilities: Awaited<ReturnType<GetCapabilitiesAPI['getCapabilities']>>
) => {
// TODO: investigate why using SolanaSignTransactions constant breaks treeshaking
const supportsSignTransaction = capabilities.features.includes('solana:signTransactions');//SolanaSignTransactions);
const supportsSignTransaction = capabilities.features.includes('solana:signTransaction');//SolanaSignTransactions);
const supportsSignAndSendTransaction = capabilities.supports_sign_and_send_transactions ||
capabilities.features.includes('solana:signAndSendTransaction');
const didCapabilitiesChange =
Expand Down
Loading