Add PDA wallet public seed helper#448
Open
onspeedhp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public_seedencoding.ConfidentialKeys.pdaWalletPublicSeed(...)API with 32-byte field validation.Why
PR #427 added the WebAuthn PRF adapter and intentionally kept
public_seedcaller-defined. This helper gives single-signer PDA wallets a shared encoding forprogram_id || wallet_pda || mint || token_account, reducing seed-convention drift without changing the underlying derivation or crypto.Testing
cargo test -p solana-zk-sdk pda_wallet_public_seed --libcargo build --target wasm32-unknown-unknown -p solana-zk-sdk-wasm-jscargo test -p solana-zk-sdk-wasm-js --target wasm32-unknown-unknown pda_wallet_public_seed --no-run