add solid_options for solid babel plugin options#13
Open
JLarky wants to merge 1 commit intosolidjs-community:mainfrom
Open
add solid_options for solid babel plugin options#13JLarky wants to merge 1 commit intosolidjs-community:mainfrom
JLarky wants to merge 1 commit intosolidjs-community:mainfrom
Conversation
This was referenced Oct 27, 2024
thetarnav
requested changes
Oct 27, 2024
| import * as tsup from 'tsup' | ||
| import * as esbuild from 'esbuild' | ||
| import { solidPlugin } from 'esbuild-plugin-solid' | ||
| import { type Options, solidPlugin } from 'esbuild-plugin-solid' |
Member
There was a problem hiding this comment.
Please alias Options or the while import as solid so it's obvious what Options is.
| * | ||
| * @default {} | ||
| */ | ||
| solid_options?: Options['solid'] | undefined |
Comment on lines
-250
to
+269
| solidPlugin({ solid: { generate: type.server ? 'ssr' : 'dom' } }), | ||
| solidPlugin({ | ||
| solid: { | ||
| generate: type.server ? 'ssr' : 'dom', | ||
| ...type.solid_options, | ||
| }, | ||
| }), |
Member
There was a problem hiding this comment.
imo this should be added to preset, not entry, options as (type: EntryType) => SolidPluginOptions. And without merging with the default one. Either user provides options or we.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows you to tweak solid options, like using
hydratableoption.