Fix deprecation warning - #104
Merged
Merged
Conversation
MIME::Type now expects a hash of arguments for its constructor.
Member
|
Is this backwards compatible or do we need to specify a version constraint on the mime-types gem? |
Contributor
Author
|
It appears that the hash initialization has been supported since this PR which shipped as 2.0 in October 2013. I'm happy to add a |
Member
|
Yes please! |
Contributor
Author
|
Done! |
Member
|
Sorry, I think ">= 2" is what we need, since 2 is just fine. |
Since we now use the hash-based initializer we need at least v2.
BrentWheeldon
force-pushed
the
deprecation
branch
from
April 9, 2026 19:57
78a67cf to
12fdef0
Compare
Contributor
Author
|
🤦🏻 Indeed... Fixed! |
jarednorman
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MIME::Type now expects a hash of arguments for its constructor.