Skip to content

Enable/Disable store credit at checkout step - #3661

Closed
DanielePalombo wants to merge 1 commit into
solidusio:mainfrom
DanielePalombo:nebulab/selectable-store-credits
Closed

Enable/Disable store credit at checkout step#3661
DanielePalombo wants to merge 1 commit into
solidusio:mainfrom
DanielePalombo:nebulab/selectable-store-credits

Conversation

@DanielePalombo

Copy link
Copy Markdown
Contributor

Description
This PR adds the ability for the user to enable/disable the store credits at checkout step

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Comment thread core/db/migrate/20200525083006_add_use_store_credits_to_spree_orders.rb Outdated
@DanielePalombo
DanielePalombo force-pushed the nebulab/selectable-store-credits branch from 2232dbb to 8e3b990 Compare June 12, 2020 16:23
@DanielePalombo
DanielePalombo force-pushed the nebulab/selectable-store-credits branch from 8e3b990 to b040a9c Compare June 19, 2020 08:47
@waiting-for-dev

Copy link
Copy Markdown
Contributor

Hey @DanielePalombo, would you still like to add this feature on solidus?

@waiting-for-dev

Copy link
Copy Markdown
Contributor

I'll closing it now, but if you find the time to keep working on it, I'll happily reopen 🙂

@DanielePalombo

Copy link
Copy Markdown
Contributor Author

Hi @waiting-for-dev ,
Sorry, I didn't answer you previously. I would like to work on it, but I have the time.

@waiting-for-dev

Copy link
Copy Markdown
Contributor

No worries @DanielePalombo, reopening 🙂

@kennyadsl kennyadsl added the type:enhancement Proposed or newly added feature label Aug 24, 2022
@waiting-for-dev waiting-for-dev added the changelog:solidus_core Changes to the solidus_core gem label Aug 30, 2022
@fthobe

fthobe commented Feb 8, 2025

Copy link
Copy Markdown
Contributor

@jarednorman this is low hanging fruit and makes sense also for us. Is this up for grabs?

@jarednorman

Copy link
Copy Markdown
Member

Sorry, I didn't answer you previously. I would like to work on it, but I have the time.

Ron Howard voice: He did not have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem type:enhancement Proposed or newly added feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants