OrderPromotions: Validate promotion uniqueness per order - #6424
Merged
mamhoff merged 1 commit intoMar 10, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6424 +/- ##
=======================================
Coverage 89.50% 89.50%
=======================================
Files 981 981
Lines 20476 20477 +1
=======================================
+ Hits 18327 18328 +1
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamhoff
force-pushed
the
validate-order-promotion-uniqueness
branch
from
March 5, 2026 16:23
e45d72d to
aa8a4b1
Compare
OrderPromotion objects connect a promotion to an order (e.g. through entering a promotion code). If an order is already connected to an order through an order promotion, we don't need to add a second record.
mamhoff
force-pushed
the
validate-order-promotion-uniqueness
branch
from
March 9, 2026 12:45
aa8a4b1 to
25ab4c5
Compare
tvdeyen
approved these changes
Mar 9, 2026
adammathys
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrderPromotion objects connect a promotion to an order (e.g. through entering a promotion code). If an order is already connected to an order through an order promotion, we don't need to add a second record.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: