Skip to content

OrderPromotions: Validate promotion uniqueness per order - #6424

Merged
mamhoff merged 1 commit into
solidusio:mainfrom
mamhoff:validate-order-promotion-uniqueness
Mar 10, 2026
Merged

OrderPromotions: Validate promotion uniqueness per order#6424
mamhoff merged 1 commit into
solidusio:mainfrom
mamhoff:validate-order-promotion-uniqueness

Conversation

@mamhoff

@mamhoff mamhoff commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Summary

OrderPromotion objects connect a promotion to an order (e.g. through entering a promotion code). If an order is already connected to an order through an order promotion, we don't need to add a second record.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@mamhoff
mamhoff requested a review from a team as a code owner March 5, 2026 15:49
@github-actions github-actions Bot added the changelog:solidus_promotions Changes to the solidus_promotions gem label Mar 5, 2026
@codecov

codecov Bot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.50%. Comparing base (3896980) to head (25ab4c5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6424   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files         981      981           
  Lines       20476    20477    +1     
=======================================
+ Hits        18327    18328    +1     
  Misses       2149     2149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mamhoff
mamhoff force-pushed the validate-order-promotion-uniqueness branch from e45d72d to aa8a4b1 Compare March 5, 2026 16:23
OrderPromotion objects connect a promotion to an order (e.g. through
entering a promotion code). If an order is already connected to an order
through an order promotion, we don't need to add a second record.
@mamhoff
mamhoff force-pushed the validate-order-promotion-uniqueness branch from aa8a4b1 to 25ab4c5 Compare March 9, 2026 12:45
@mamhoff
mamhoff merged commit aa11fbd into solidusio:main Mar 10, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_promotions Changes to the solidus_promotions gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants