Skip to content

fix(locale selection): Use international language icon - #6439

Merged
jarednorman merged 1 commit into
solidusio:mainfrom
blish:use-language-icon
Apr 17, 2026
Merged

fix(locale selection): Use international language icon#6439
jarednorman merged 1 commit into
solidusio:mainfrom
blish:use-language-icon

Conversation

@tvdeyen

@tvdeyen tvdeyen commented Apr 15, 2026

Copy link
Copy Markdown
Member

Summary

The icon for language is not a globe and not flags, because countries are not synomous to spoken languages. Using the language symbol instead.

This allows us to use the globe icon for a timezone select later.

Ref: https://languageicon.org

CleanShot 2026-04-15 at 19 23 19@2x

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

The icon for language is not a globe and not flags, because countries
are not synomous to spoken languages. Using the language symbol instead.

This allows us to use the globe icon for a timezone select later.

Ref: https://languageicon.org
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
@tvdeyen
tvdeyen requested a review from a team as a code owner April 15, 2026 20:56
@github-actions github-actions Bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_admin labels Apr 15, 2026
@tvdeyen tvdeyen added the type:enhancement Proposed or newly added feature label Apr 15, 2026
@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (1931ee8) to head (4a9d090).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6439   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         990      990           
  Lines       20792    20792           
=======================================
  Hits        18644    18644           
  Misses       2148     2148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jarednorman
jarednorman merged commit 7be98b7 into solidusio:main Apr 17, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_admin changelog:solidus_backend Changes to the solidus_backend gem type:enhancement Proposed or newly added feature

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants