Fix unnecessary revision creation when only a column from the globalIgnoreColumns list is updated - #675
Merged
Conversation
Contributor
Author
|
@VincentLanglet When you have some time, could you please take a look? |
VincentLanglet
previously approved these changes
Mar 24, 2026
Member
|
(Triggering the CI) |
valkars
force-pushed
the
hotfix/ignore-columns
branch
2 times, most recently
from
March 24, 2026 15:16
902b4e9 to
04b6cc5
Compare
…gnoreColumns list is updated
valkars
force-pushed
the
hotfix/ignore-columns
branch
from
March 24, 2026 15:19
04b6cc5 to
0b9349f
Compare
Contributor
Author
|
I have fixed all issues except false error by rector Don't know how to deal with it |
VincentLanglet
approved these changes
Mar 24, 2026
Member
|
Thanks |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
When only a column from the globalIgnoreColumns list is updated, a new revision is incorrectly created, and an update is attempted on a non-existent record in the audit table.
Example: last_login and updated_at are in globalIgnoreColumns, and the following SQL is executed:
I added a check for globalIgnoreColumns, and now no new revision is created and no update is executed.
I am targeting this branch, because this fix is backwards compatible.
Changelog
### Fixed Fix unnecessary revision creation when only a column from the globalIgnoreColumns list is updated