Fix slow halt reboot test#251
Open
jkmar wants to merge 1 commit into
Open
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
anders-nexthop
approved these changes
May 21, 2025
anders-nexthop
left a comment
There was a problem hiding this comment.
This change looks fine to me, and the test is passing. @jkmar you will have better luck getting visibility into PRs if you create a corresponding issue for them; individual PRs do not get looked at very often if at all, whereas issues are generally triaged every couple of weeks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_execute_reboot_fail_halt_timeouttest was very slow - it took around a minute:The reason is that within this while loop: https://github.com/sonic-net/sonic-host-services/blob/master/host_modules/reboot.py#L131, only sleep in the body was mocked, but the condition wasn't, which caused the loop to be run continuously until the halt timer expired.
This PR fixes the issue, by mocking the monotonic clock used in the loop's condition, so that it ends earlier.
Now the test takes much less time: